Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some italics syntax consistency issues #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryankinderman
Copy link

  • Added skipping escaped italics tokens when end matching
  • Updated prefix/suffix constraints for start/end patterns to be more consistent with behavior of the Markdown Dingus
  • Added constraint on start pattern so that it doesn't match if there isn't an end token within the same paragraph
  • Added sample.md to syntax dir to use for testing syntax consistency w/the dingus

…t patterns to not match if not followed by the end token in the same paragraph, and to not match on start or end patterns if improperly prefixed or suffixed in a way more consistent with the markdown dingus
@RubenVerborgh
Copy link

Interesting work. However, I believe there are still some cases that are not covered. For example:

*half*-italic
# Title 1
*half-*italic
# Title 2

The second title does not get correct syntax highlighting, even not after patching.

@ryankinderman
Copy link
Author

Yea, I'm sure there are cases that still aren't covered. I basically tried to fix the handful of cases that were not working for me at the time. It's hard to be comprehensive with nothing to use as a reference except the "Dingus". Would love to see others jump in and fix things that are still missing.

@silverhook
Copy link

I tried it and I get a similar bug as @RubenVerborgh, but slightly different.

In his example, the Title doesn't get highlighted. In my case just every _ after the first # seems to be shown as a syntax error.

The bug I describe here is not present in @tpope's current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants