C_FindObjects: init list to reload new objects #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pepipox to get this over the line the issues in the unit tests are that I mock certain DB functions and when changing on how the DB functions are called internally messes up the expected mocking in the unit tests. For instance, you'll see these errors: 2022-09-19T17:23:17.2159476Z [ ERROR ] --- No entries for symbol __wrap_sqlite3_step.
2022-09-19T17:23:17.2159816Z ../test/unit/test_db.c:157: error: Could not get value to mock function __wrap_sqlite3_step
2022-09-19T17:23:17.2160201Z ../test/unit/test_db.c:1321: note: Previously returned mock value was declared here
2022-09-19T17:23:17.2160409Z Can you update the mocking in the unit tests? Then we can pull this change in and cut a release for distros to pick up. |
|
Hi @williamcroberts |
|
Need the CI to pass.
…________________________________
From: Vincent JARDIN ***@***.***>
Sent: Thursday, October 27, 2022 4:59 PM
To: tpm2-software/tpm2-pkcs11 ***@***.***>
Cc: Roberts, William C ***@***.***>; Mention ***@***.***>
Subject: Re: [tpm2-software/tpm2-pkcs11] C_FindObjects: init list to reload new objects (PR #789)
please, @williamcroberts<https://github.com/williamcroberts> and @pepipox<https://github.com/pepipox> , what's the status of this pull request ?
—
Reply to this email directly, view it on GitHub<#789 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEHNWB6SZGT3G6AXFI2P46DWFL3NHANCNFSM6AAAAAAQQ2WNBM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
If the db is modified externally while an application has the db store open, new objects are not seen by the application becuase it occurs after the application has loaded the list of tobjects. To correct this, reload the list on every C_FindObjectsInit call. Signed-off-by: jupana, Juan Narino <[email protected]> Signed-off-by: William Roberts <[email protected]>
williamcroberts
force-pushed
the
reloadObjectsOnCFindInit
branch
from
41fd6a9
to
9ad6002
Compare
|
Just rebased your remote reloadObjectsOnCFindInit branch onto master, likely still have the mock test issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the db is modified externally while an application has the db store open, new objects are not seen by the application becuase it occurs after the application has loaded the list of tobjects. To correct this, reload the list on every C_FindObjectsInit call.
Signed-off-by: jupana, Juan Narino [email protected]
Signed-off-by: William Roberts [email protected]