Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv build #61

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Use uv build #61

merged 6 commits into from
Sep 5, 2024

Conversation

tpgillam
Copy link
Owner

@tpgillam tpgillam commented Sep 4, 2024

uv build takes about half the time of the old make build on my system. New in uv 0.4.5.

@tpgillam tpgillam self-assigned this Sep 4, 2024
@tpgillam tpgillam requested a review from Rupt September 4, 2024 22:51
@tpgillam tpgillam marked this pull request as ready for review September 4, 2024 22:51
Rupt
Rupt previously approved these changes Sep 5, 2024
Copy link
Collaborator

@Rupt Rupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change. Workflows pass. In future, we might benefit from a little documentation for contributors to install a compatible uv.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kesterlester
Copy link
Contributor

I am reminded of A.C.Clarke's "Any sufficiently advanced technology is indistinguishable from magic" given that most of the diffs largely consist of making new lines of code be anagrams of old lines of code.

@tpgillam tpgillam merged commit ad26e9e into master Sep 5, 2024
30 checks passed
@tpgillam tpgillam deleted the tg/uv_build branch September 5, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants