Oper leader elect #115
Closed
Oper leader elect #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to conform to the standard Go project layout: https://github.com/golang-standards/project-layout?tab=readme-ov-file#cmd Signed-off-by: Tom Pantelis <[email protected]>
- Use sigs.k8s.io/controller-runtime alias for SetupSignalHandler - Set 'ctx' to the SetupSignalHandler context - Pass 'cfg' to ctrl.NewManager instead of creating new one Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Fixes: "Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead" Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Mainly informational comments. Signed-off-by: Tom Pantelis <[email protected]>
...to conform to the standard Go project layout: https://github.com/golang-standards/project-layout?tab=readme-ov-file#internal Signed-off-by: Tom Pantelis <[email protected]>
...instead of leader-for-life. The latter was implemented in the operator SDK early on before controller-runtime supported leader-with-lease. However leader-with-lease is the preferred method and leader-for-life is being proposed for deprecation (see operator-framework/operator-lib#117). Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.