-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaults #191
Add defaults #191
Conversation
I'd like to have it by default off. Otherwise, I'm happy to also allow it to be configurable where it's added. |
OK, I need help, I have no idea what’s going on with those Why does only my test case fail on Python 3.9 even though I copied the setup from |
That's half the work in this project, to figure out the differences between Python versions and make it work everywhere. I'll have a look at some point, but no idea when I'll have time for this. |
Ugh, I figured it out. This will bite you in the future, I hope you find a way to make it less flaky. I filed #194 to explore this. This PR is now ready! Changelog, readme, code, tests! |
Sorry, I'm not open to a fallback issue and working around the test. We should figure out here and now why this is the case and avoid it. |
I’m avoiding it by not using that syntax, in the same way your main test does. This PR is completely independent of this problem now, I just happened to run into it while developing this PR. I’m happy to help, but please don‘t drag this unrelated PR into it. |
Supersedes #103, fixes #48
In the previous PR, I added them to types, this time I’m adding it to the string. I think both have arguments pro and contra. Should it be configurable?