Fix CI #517
Merged
Fix CI #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/msrv
branch
from
adef6f2
to
cea9b80
Compare
|
Just noting that what I've started to do in other projects is just to pin the version in the MSRV CI job. It's what anyone who really needed that support could do, and I still know when the direct crate finally needs a newer version. |
|
I feel like 1.70 is old enough that nobody is likely relying on something older than it (and still pulling in updates like the upcoming |
jplatte
force-pushed
the
jplatte/msrv
branch
from
b9204f7
to
814373a
Compare
LucioFranco
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tokio-util v0.7.12 has bumped its MSRV, and CI is failing.
cargo public-api-cratesis also failing due to rustdoc JSON changes.Solution
Have the MSRV job downgrade tokio-util, pin a nightly for public-api-crates. Also upgrade the checkout action, bc. why not.