Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tower to v0.5 #503

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Bump tower to v0.5 #503

merged 2 commits into from
Aug 13, 2024

Conversation

paolobarbolini
Copy link
Contributor

I see tower 0.5 came out but tower-http hadn't upgraded yet. I've fixed all compilation issues and now it seems to work.

@jplatte jplatte changed the title Bump tower-http to v0.5 Bump tower to v0.5 Aug 13, 2024
jplatte
jplatte approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like this is a breaking change, as tower is included in package.metadata.cargo-public-api-crates.allowed in Cargo.toml.

Mind adding an entry to tower-http/CHANGELOG.md?

@paolobarbolini
Copy link
Contributor Author

Done

jplatte
jplatte reviewed Aug 13, 2024
View reviewed changes
tower-http/CHANGELOG.md Outdated Show resolved Hide resolved
@jplatte jplatte merged commit 3f98dc1 into tower-rs:main Aug 13, 2024
11 checks passed
@mozzenior mozzenior mentioned this pull request Sep 10, 2024
Closed
@jplatte jplatte mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolobarbolini @jplatte