Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make http-body and http-body-util dependencies optional #477

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Make http-body and http-body-util dependencies optional #477

merged 2 commits into from
Mar 11, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 5, 2024 •
edited
Loading

Motivation

Some features do not seem to use http-body crate, and some of them also not using http-body-util crate as the dependencies.

Solution

Makes http-body and http-body-util dependencies optional.

This is a breaking change as this disables body module conditionally,

@jplatte
Copy link
Collaborator

jplatte commented Mar 11, 2024

Thanks for the PR! Can you add a # Unreleased section to tower-http/CHANGELOG.md and describe the changes (esp. the breaking one) there?

@tottoto
Copy link
Contributor Author

tottoto commented Mar 11, 2024

Added the changelog.

jplatte
jplatte approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@jplatte jplatte merged commit cce54a8 into tower-rs:main Mar 11, 2024
11 checks passed
@tottoto tottoto deleted the make-http-body-and-http-body-util-optional branch March 11, 2024 21:09
@jplatte jplatte mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @jplatte