Unbreak CI #385
Merged
Unbreak CI #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since tower-http doesn't maintain a Cargo.lock in git, this check breaks very often due to dependencies doing their own maintenance. The signal / noise ratio of this check was very low.
Merged
|
I'd rather have specific exceptions than accepting all duplicate dependencies |
davidpdrsn
approved these changes
Jul 19, 2023
|
I'm okay either way 😅 |
The problem with this, as mentioned in the commit message, is that CI frequently breaks from it from dependencies just doing their regular maintenance and upgrading dependencies. I also like avoiding duplicate dependencies, very much (recently went to upgrade syn in a bunch of places that hadn't upgraded to 2.0 yet). But more often than not, it's non-trivial to fix these and unrelated contributions get stuck on it, especially when the project isn't receiving frequent updates (like tower-http, currently). |
|
Fair enough |
Nehliin
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI is failing in other PRs, with no fault of the PR authors.
Solution
Stop erroring on duplicate dependencies in the
cargo-denycheck.