Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci config #378

Merged
merged 6 commits into from
Jun 22, 2023
Merged

Update ci config #378

merged 6 commits into from
Jun 22, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Jun 22, 2023

Motivation

Resolves the ci warnings and improves the ci maintainability.

Solution

Resolves the ci warnings

  • Replaces actions-rs/toolchain with dtolnay/rust-toolchain.
  • Replaces actions-rs/cargo with run.
    • Same as actions-rs/toolchain, actions-rs/cargo is not maintained.
  • Update to Swatinem/rust-cache@v2 from version 1.

Other fixes

  • YAML indent style.

Miscellaneous improvements

  • Uses the latest stable version 3 of actions/checkout.
  • Uses taiki-e/install-action to install cargo-hack.
    • This action is maintained by the same author of cargo-hack.
    • It is used in a lot of projects (for example tokio project).

@tottoto tottoto marked this pull request as ready for review June 22, 2023 11:19
Copy link
Collaborator

@Nehliin Nehliin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nehliin Nehliin merged commit d895678 into tower-rs:master Jun 22, 2023
11 checks passed
@tottoto tottoto deleted the update-ci branch June 22, 2023 12:49
gezihuzi pushed a commit to gezihuzi/tower-http that referenced this pull request Jul 19, 2023
* Replace actions-rs/toolchain with dtolnay/rust-toolchain

* Replace actions-rs/cargo with run

* Update Swatinem/rust-cache to v2

* Fix yaml indent style

* Use stable version of actions/checkout

* Use taiki-e/install-action to install cargo-hack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants