Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify example function condition #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

doyn511
Copy link

@doyn511 doyn511 commented Jan 14, 2025

같은 종류의 함수는 반환 타입 통일하기 섹션의 예시 중 주석에 쓰여진이름은 20자 미만이어야 해요에 맞도록 개선해보기checkIsNameValid 조건을 수정했어요.

스크린샷 2025-01-15 00 54 09

Copy link

vercel bot commented Jan 14, 2025

@doyn511 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

return {
ok: false,
reason: 'Names can be up to 20 characters long.',
reason: 'Names cannot be more than 20 characters long.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about rephrasing it to "Name (or user-name) cannot be longer than 20 characters?"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. As I change Names to Name, I also modified the above conditions the same.

Copy link
Collaborator

@Kimbangg Kimbangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants