Fix: Avoid implicit type coercion in validation logic examples #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minseong0324 is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
Kimbangg
reviewed
Jan 15, 2025
code/examples/form-fields.md
Outdated
| @@ -38,7 +38,8 @@ export function Form() { | |||
| <div> | |||
| <input | |||
| {...register("name", { | |||
| validate: (value) => (!value ? "이름을 입력해주세요." : ""), | |||
| validate: (value) => | |||
| (value.trim() === "" ? "이름을 입력해주세요." : ""), | |||
There was a problem hiding this comment.
I think it would be good if "Please enter your name." is displayed even when the value is nullish.
How about handling this with a utility function like isEmptyStringOrNil(value)?
There was a problem hiding this comment.
Thanks for your good comment. I applied isEmptyStringOrNil function to verify nullish value.
minseong0324
force-pushed
the
chore/implicit-coercion
branch
2 times, most recently
from
6230fcb to
2559593
Compare
minseong0324
force-pushed
the
chore/implicit-coercion
branch
from
2559593 to
663c6a9
Compare
…mentals into chore/implicit-coercion
Kimbangg
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!value) in the validation logic with an explicit comparison usingvalue.trim() === "".ref: #21