Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numberToHangul로 큰 숫자 변환시 불필요한 단위 제거 #314

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

wet6123
Copy link
Contributor

@wet6123 wet6123 commented Jan 7, 2025

Overview

  1. numberToHangul을 이용하여 1억 이상의 숫자를 변환할 때 불필요한 단위가 붙어서 출력되는 버그를 수정했습니다.
  2. 이를 검증 할 수 있는 테스트를 추가했습니다.

resolved #311

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: d3f612a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 4:10pm

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@okinawaa okinawaa merged commit 40ac51f into toss:main Jan 8, 2025
2 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:numberToHangul의 숫자 변환 오류
2 participants