Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CSS 파일에서 공백이 있는 폰트 이름에 따옴표 추가 및 불필요한 * 제거 #248

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

YuHyeonWook
Copy link
Contributor

Overview

  • 공백이 포함된 폰트 이름(Toss Product Sans, Bazier Square 등)에 따옴표를 추가하여 CSS의 표준에 맞게 수정하였습니다.
  • *body로 잘못 지정되어 있다고 생각하여 CSS 선택자를 body로 수정하여 불필요한 *를 제거하였습니다.

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

Copy link

changeset-bot bot commented Sep 14, 2024

⚠️ No Changeset found

Latest commit: 47572b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-hangul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 0:49am

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (3a97440) to head (47572b2).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          36       36           
  Lines         601      601           
  Branches      145      145           
=======================================
  Hits          599      599           
  Misses          2        2           

Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

�매번 감사합니다!!

@okinawaa okinawaa merged commit f3e9024 into toss:main Sep 14, 2024
10 checks passed
@YuHyeonWook YuHyeonWook deleted the fix/font-family-and-body-selector branch September 14, 2024 03:28
@YuHyeonWook
Copy link
Contributor Author

오픈소스 읽고 덕분에 많이 배워갑니다!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants