Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: Show notification on a badly rated site #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrshu
Copy link

@mrshu mrshu commented Sep 20, 2014

  • Mimic notifications on Firefox and Chrome tos;dr extensions

Signed-off-by: mr.Shu [email protected]

----8<----

Couple of questions:

  • right now shows notifications every time the user load a bad rated URL. Should we show this just once per browser session?
  • on Firefox clicking on a notification will open the tosdr.org site with the service's rating. Should we do the same here?

* Mimic notifications on Firefox and Chrome tos;dr extensions

Signed-off-by: mr.Shu <[email protected]>
@xMartin
Copy link
Member

xMartin commented Sep 21, 2014

I'd like to see as much consistency between the different browser plugins as possible. If there's open questions related to any extension and not only Safari let's discuss it here: https://github.com/tosdr/browser-extensions/issues

@mrshu
Copy link
Author

mrshu commented Sep 21, 2014

@xMartin I completely agree on keeping as much consistency as possible.

However, I'd say that there already is status quo since the Firefox, Chrome and Opera extensions behave in the same way, which means showing the notification once per two weeks (on Chrome and Opera this is actually broken at the moment). Can you please create the issue in the other repository?

I'll at least make sure that the notification URL links to the description at tosdr.org.

@xMartin
Copy link
Member

xMartin commented Sep 21, 2014

Please go ahead and create issues yourself while you're on it. Thanks for your effort!

* Open tosdr.org review for a service when clicked on notification window.

Signed-off-by: mr.Shu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants