Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittest error with pydantic2.9 #1734

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Oct 11, 2024

Description

Closes #1732 #1727

Remove allOf because of: https://pydantic.dev/articles/pydantic-v2-9-release#changes

Motivation and Context

Upgrade dependencies and fix ci error

How Has This Been Tested?

make test_sqlite

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11301811305

Details

  • 14 of 15 (93.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 89.013%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/contrib/fastapi/init.py 0 1 0.0%
Totals Coverage Status
Change from base Build 11271863554: 0.007%
Covered Lines: 5981
Relevant Lines: 6604

💛 - Coveralls

@abondar abondar merged commit c7d5be1 into tortoise:develop Oct 13, 2024
7 checks passed
@waketzheng waketzheng deleted the support-pydantic2.9 branch November 6, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unittest failed after upgraded pydantic to 2.9.2
3 participants