Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove port from an mssql dsn when using named instances.
Motivation and Context
MSSQL named instances use dynamic port numbers. You can either connect directly to the port, or to the named instance.
Providing a DB URL like
mssql://user:pass@host\instance/db?driver=FreeTDS
will result in a DSN which looks likeDRIVER=FreeTDS;SERVER=host\instance,1433;UID=user;PWD=pass;
because the default port is added. This fails to connect, because the instance is not listening on port 1443.#1566
How Has This Been Tested?
I have only tested locally with and without named instances.
Checklist: