Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement for FastAPI lifespan support (#1371) #1541

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

waketzheng
Copy link
Contributor

  • Add a new class RegisterTortoise which can be used in lifespan context
  • Enhancement register_tortoise to auto run in lifespan context, but echo deprecated warning

Description

Support register in fastapi's lifespan and leave register_tortoise there to compare old version

Motivation and Context

For some running projects, people may want to only upgrade dependencies without changing any code.

While for new project, it is more flexibility to use async with format to register db.

How Has This Been Tested?

make test
cd examples/fastapi && PYTHONPATH=. pytest _tests.py

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MihaiBalint
Copy link

Would be nice to have this merged

@abondar
Copy link
Member

abondar commented Apr 26, 2024

Hi!

Could you please rebase it to actual develop branch

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8856984032

Details

  • 0 of 51 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 87.967%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/contrib/fastapi/init.py 0 51 0.0%
Totals Coverage Status
Change from base Build 8850757408: -0.5%
Covered Lines: 5733
Relevant Lines: 6424

💛 - Coveralls

@abondar abondar merged commit 7ded5c7 into tortoise:develop Apr 27, 2024
7 checks passed
@waketzheng waketzheng deleted the fastapi-lifespan-support branch May 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants