fix: nvarchar field filtering bug for non-ascii characters #1441

mm74noroozi · 2023-07-28T19:18:04Z

Description

in mssql when we want to filter non-ascii character we should use it in the format like:

select * from MyTable where name=N'سلام'

and if we use it like other ascii variables we get empty response

select * from MyTable where name='سلام'

in mssql it is impossible to query on non-ascii words

I have added all test for charfield to this field also I have tested create and filter non-ascii chars

long2ice · 2023-07-29T04:39:08Z

CHANGELOG.rst

+------
+Added
+^^^^^
+- NVARCHAR non-ascii char support on mssql


Just add in 0.20.0 because which is not released yet

long2ice · 2023-07-29T04:41:23Z

tortoise/contrib/mssql/field_types.py

@@ -0,0 +1,5 @@
+class NVARCHAR:


What about NVarChar?

long2ice · 2023-07-29T04:41:24Z

tortoise/contrib/mssql/fields.py

+from tortoise.contrib.mssql.field_types import NVARCHAR
+
+
+class NVARCHAR(CharField):


What about NVarCharField?

mm74noroozi added 5 commits July 27, 2023 01:17

feat: add mssql nvarchar

16fd8a5

update CONTRIBUTORS.rst

377f904

fix: logical and typo mistakes

b1cffdd

feat: add filter test on nvarchar field

4b608b6

update change log

c64798f

long2ice reviewed Jul 29, 2023

View reviewed changes

		from tortoise.contrib.mssql.field_types import NVARCHAR


		class NVARCHAR(CharField):