add melt-ui toc in (pages) #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Hi @grmbyrn It looks good. There is only one thing I don't like it. The vertical scroll bar in the Index page.
I would use only the window scroll bar. I think nested scroll bars are a pain.
|
ACK b72f1c3 |
josecelano
added a commit
that referenced
this pull request
Nov 22, 2024
5078729 Applied changes from TGlide's PR consistently across the website (TGlide) 59a10b8 remove PagesWrapper 100vh, make Toc sticky on desktop up (Graeme Byrne) a39f573 remove vertical scroll bar (Graeme Byrne) Pull request description: * Remove vertical scroll bar on all `routes/(pages)` as mentioned [here](#113 (review)) using the following: ``` .content-preview { overflow-y: scroll; scrollbar-width: none; -ms-overflow-style: none; padding-top: 0rem; } ``` * Edit lists on all `routes/(pages)` to ensure style consistency. ACKs for top commit: josecelano: ACK 5078729 Tree-SHA512: df3e02cded2f2b4a36a0cf542051c05f8aff21ded49d607ab33c6434f21fa01198d160200086adc6b9e4a9660b2a629f4d010892fe17e6832c1caae62ed3628a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routes/(pages).routes/(pages)by extracting intoPagesWrapper.svelte.routes/(pages)/about/+page.svelteintoconstants/constantsto maintain consistency with data used in other tables on the website.