Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul core Tracker: extract authentication #1192

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Overhaul core Tracker: extract authentication #1192

merged 10 commits into from
Jan 21, 2025

Conversation

josecelano
Copy link
Member

Overhaul core Tracker: extract authentication.

@josecelano
refactor: [torrust#1191] create dir for mod
88560ce 
We will add more mods inside. This is part of a bigger refactor.
@josecelano josecelano linked an issue Jan 20, 2025 that may be closed by this pull request
Overhaul core Tracker: extract authentication #1191
Closed
@josecelano josecelano self-assigned this Jan 20, 2025
@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 20, 2025
@josecelano josecelano requested a review from da2ce7 January 20, 2025 15:30
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.97590% with 30 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (e630e5f) to head (6584fe4).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/authentication/mod.rs 94.07% 17 Missing and 1 partial ⚠️
src/core/databases/mysql.rs 0.00% 8 Missing ⚠️
src/core/databases/sqlite.rs 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1192      +/-   ##
===========================================
+ Coverage    77.46%   77.65%   +0.19%     
===========================================
  Files          183      184       +1     
  Lines        12539    12651     +112     
  Branches     12539    12651     +112     
===========================================
+ Hits          9713     9824     +111     
  Misses        2662     2662              
- Partials       164      165       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano force-pushed the 1191-overhaul-core-tracker-extract-authentication branch from 5b12115 to 562de4d Compare January 20, 2025 17:50
@josecelano josecelano force-pushed the 1191-overhaul-core-tracker-extract-authentication branch from 562de4d to 5aae933 Compare January 20, 2025 17:54
@josecelano josecelano force-pushed the 1191-overhaul-core-tracker-extract-authentication branch from 5aae933 to 39c2a8f Compare January 20, 2025 17:58
@josecelano
refactor: [torrust#1191] remove duplicate tests for private tracker
f41a524 
There were copied to the authentication module.
@josecelano josecelano marked this pull request as ready for review January 21, 2025 11:55
@josecelano
Copy link
Member Author

ACK 6584fe4

@josecelano josecelano mentioned this pull request Jan 21, 2025
Closed
@josecelano josecelano merged commit 757126d into torrust:develop Jan 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: extract authentication
1 participant
@josecelano