new approach for builder pattern

[miladvafaeifard]

feel free to make suggestion and improvements based on the approach.

[miladvafaeifard]

@torokmark, have you checked my suggestion of the changes? :)

[torokmark]

Hi Milad,

Nice approach. Though, I am a bit concerned about the followings:

1. Even though, Build interface is a general type with type param, it requires the implementor class to have setAge, setPhone, setAddress methods.
   What if I am intended to use Build with other type paramater like Car. I cannot use it, since it makes me implement setPhone in Car, but a car does not have phone number.
   In my point of view, Build is quite misleading in this way.

   Let me suggest the following.

   Let us have a Build interface with type parameter, and this interface has only one method, like build(): T

namespace BuilderPattern {
    export interface Builder<T> {
        build(): T;
    }

    // ...
}

2. Director with UserBuilder parameter in its constuctor is a bit smelly in this way. Why does not makeUser return a User?

I would recommend the following here:

export class UserDirector implements Director<User> {

    constructor(private userBuilder: UserBuilder){}


    create(): User {
        if(this.userBuilder.Name === 'Jancsi') {
            this.userBuilder.setAge(12)
            .setPhone("0123456789")
            .setAddress("asdf");
        } else {
            this.userBuilder.setAge(0)
            .setPhone("xxxxxxxxx")
            .setAddress("xxxx");
        }
        return this.userBuilder.build()
    }
}

[miladvafaeifard]

Hi Mark 👋

Your approach makes much more sense to me, hence I completely agree on this. Shall i refactor with your approach in my next commit in this thread with a quick polish? 😃

[torokmark]

@miladvafaeifard , yes please, it would be great if you did refactoring on the approach.

I am always happy to see people contributing. Thank you

[miladvafaeifard]

Hi @torokmark,

I refactored and polished based on your suggestion. I would appreciate if you could review the change. and provide your thoughts on this.

[torokmark]

As I see, getUser is not used, and seems superfluous, since we have a build method.

[torokmark]

It is a bit misleading to have getter by declaring with get and setters following Java POJO.
Here, methods should be introduced with set keyword.