importer: use page if a post and page clash with slugs #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may not want this in your code, but could be useful for others who hit this issue. |
This is due to an upstream issue with wordpress where if you set permalink to /%postname%/ it allows a page and post to have the same slug. But when viewing via the slug wordpress always picks the page. https://core.trac.wordpress.org/ticket/13459
ahayzen-kdab
force-pushed
the
fix-clashing-posts-and-pages
branch
from
feef216
to
389a0fb
Compare
5 tasks
ahayzen-kdab
commented
Jan 31, 2024
| # We are creating a new page as the wp_post_id doesn't exist | ||
| # however we may have a collision of slugs between page and post types | ||
| # https://core.trac.wordpress.org/ticket/13459 | ||
| slug_post = self.page_model_class.objects.get( |
There was a problem hiding this comment.
note if wp_post_parent support from #176 was added, this would need to consider a slug_post with the same parent as the page and not just any slug page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to an upstream issue with wordpress where if you set permalink to /%postname%/ it allows a
page and post to have the same slug. But when viewing via the slug wordpress always picks the page.
https://core.trac.wordpress.org/ticket/13459
(Description)
Ticket URL:
Testing
Documentation.