Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Draft: Trial VWO smart code (for staging only for the time being) #519

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

helenb
Copy link
Member

@helenb helenb commented Aug 2, 2023

Link to Ticket

Description of Changes Made

Adds a snippet for the VWO smart code, which allows A / B testing. This is initially so Dot can test it on staging. Before this is deployed to production there is further work to be done to ensure that this code is only applied once cookies are approved. We'd normally handle that with GTM, but they specifically advise not to set this code in GTM due to flickers.

How to Test

View source / inspect on any page and see the tag in place

Screenshots

Expand to see more

Screenshot 2023-08-02 at 14 07 15

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why.
  • Tests and linting passes.
  • Consider updating documentation. If you don't, tell us why.
  • If relevant, list the environments / browsers in which you tested your changes.

@helenb helenb requested a review from chris-lawton August 2, 2023 13:08
@chris-lawton
Copy link
Member

Is Dot aware that this won't run on /careers as it's a separate site?

@helenb helenb marked this pull request as draft August 2, 2023 13:11
@helenb helenb self-assigned this Aug 2, 2023
@helenb
Copy link
Member Author

helenb commented Aug 2, 2023

Is Dot aware that this won't run on /careers as it's a separate site?

Good point - I'll mention that on the ticket, but can get on staging for now if you're happy.

@chris-lawton
Copy link
Member

Is Dot aware that this won't run on /careers as it's a separate site?

Good point - I'll mention that on the ticket, but can get on staging for now if you're happy.

Go for it : )

@zerolab
Copy link
Member

zerolab commented Aug 2, 2023

👋🏼 any reason not to use GTM for this kind of stuff?

@helenb
Copy link
Member Author

helenb commented Aug 3, 2023

👋🏼 any reason not to use GTM for this kind of stuff?

@zerolab see my MR description - they recommend against using gtm for this one.

@zerolab
Copy link
Member

zerolab commented Aug 3, 2023

@helenb fair enough. I did miss that.

I do want to flag that I will question any third-party JS that has a tracking element to it and will push against it, if I can 🙊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants