-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SnippetObjectType with SnippetInterface #405
Merged
Merged
Commits on Sep 20, 2024
-
Rename CustomInterface to AdditionalInterface
The name `CustomInterface` is too similar with `CustomPageInterface` and the upcoming `CustomSnippetInterface` and their custom interfaces settings file. Better rename it to `AdditionalInterface` so there is less confusion.
Configuration menu - View commit details
-
Copy full SHA for d092770 - Browse repository at this point
Copy the full SHA d092770View commit details -
Rename the custom interface settings file
The settings file will contain an override for the default snippet interface, in addition to the default page interface, so we're renaming it up front here.
Configuration menu - View commit details
-
Copy full SHA for 3205be2 - Browse repository at this point
Copy the full SHA 3205be2View commit details -
Replace SnippetObjectType with SnippetInterface
Fixes torchbox#386 API clients could use a field on snippet objects to determine the type of snippet they are looking at. Therefore, we change the snippet type to an interface, similar to the page interface, so it can expose a new field called `snippetType`.
Configuration menu - View commit details
-
Copy full SHA for e2729f4 - Browse repository at this point
Copy the full SHA e2729f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50cd83a - Browse repository at this point
Copy the full SHA 50cd83aView commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 33edb50 - Browse repository at this point
Copy the full SHA 33edb50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34a3c3b - Browse repository at this point
Copy the full SHA 34a3c3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09ea03b - Browse repository at this point
Copy the full SHA 09ea03bView commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4cb019a - Browse repository at this point
Copy the full SHA 4cb019aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40a16ac - Browse repository at this point
Copy the full SHA 40a16acView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.