Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendition urls are not FQDNs #401

Closed
wants to merge 1 commit into from

Conversation

dopry
Copy link
Collaborator

@dopry dopry commented Aug 30, 2024

Rendition URLs are returning only a path starting in 0.20.0 This updates it to return the same fully qualified domain name as the Image URLs. I would appreciate it if this could be backported to at least 0.20.0 to create 0.20.1 since I'm still on the 0.20.0 branch. I'm running off a fork in the mean time so not operationally impacted.

@dopry dopry force-pushed the fix/rendition-urls branch 2 times, most recently from a64f6ed to 8a2750f Compare August 30, 2024 20:37
@dopry
Copy link
Collaborator Author

dopry commented Aug 30, 2024

@zerolab I figured out what happened here. I didn't have WAGTAILADMIN_BASE_URL set, so my full_url wasn't generating a full url. I was still setting just BASE_URL. Core has dropped the use of BASE_URL, so maybe we should in grapple a this point. assuming full_url is working for both images and other things. Although I still think it should be using MEDIA_URL. I haven't looked into the construction of full_url. I'll look into it on tuesday.

@dopry
Copy link
Collaborator Author

dopry commented Aug 30, 2024

Actually I take that back. I had a custom Rendition object that specified

    graphql_fields = (
        GraphQLInt("id", required=True),
        GraphQLString("url", required=True),
        GraphQLString("width", required=True),
        GraphQLString("height", required=True),
        GraphQLImage("image", required=True),
        GraphQLString("file", required=True),
    )

and seemed to be masking the grapple.types.images.ImageRenditionObject

@dopry dopry closed this Sep 1, 2024
@dopry dopry deleted the fix/rendition-urls branch September 1, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant