Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test failing for wagtail 5.2 #378

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fixed test failing for wagtail 5.2 #378

merged 3 commits into from
Jan 5, 2024

Conversation

JakubMastalerz
Copy link
Contributor

@JakubMastalerz JakubMastalerz commented Nov 30, 2023 •
edited
Loading

Closes #377

This fixes test_src_set_invalid_format for Wagtail versions above 5.2 by:

  • Adding a new test case for those versions, with updated error message.
  • Adding conditional skipping based on active Wagtail version.

kbayliss
kbayliss requested changes Nov 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
tests/test_image_types.py Outdated Show resolved Hide resolved
tests/test_image_types.py Outdated Show resolved Hide resolved
tests/test_image_types.py Show resolved Hide resolved
tests/test_image_types.py Show resolved Hide resolved
@kbayliss kbayliss merged commit 25927d1 into torchbox:main Jan 5, 2024
13 checks passed
@kbayliss kbayliss deleted the fix/fix-test-for-wagtail-version-5.2 branch January 5, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbayliss kbayliss kbayliss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update test for Wagtail 5.2
2 participants
@JakubMastalerz @kbayliss