Bump django-crispy-forms to 2.0 #61
Conversation
- Add Python 3.12 - Remove Django 2.2, 3.0 and 3.1 - Add Django 4.1 and 4.2
| @@ -25,7 +25,7 @@ | |||
| {% if field.label and not field|is_checkbox and form_show_labels %} | |||
| {% if label_tag %}<{{ label_tag }} class="tbxforms-label-wrapper">{% endif %} | |||
| <label for="{{ field.id_for_label }}" class="tbxforms-label{% if label_size %} {{ label_size }}{% endif %}"> | |||
| {{ field.label|safe }} | |||
There was a problem hiding this comment.
These three settings are still mentioned within the README and referenced within code:
TBXFORMS_ALLOW_HTML_LABELTBXFORMS_ALLOW_HTML_HELP_TEXTTBXFORMS_ALLOW_HTML_BUTTON
Do they still have a place, do you think?
With |safe removed, I wonder if we should also remove these and rely solely on developers marking values as safe.
There was a problem hiding this comment.
At least TBXFORMS_ALLOW_HTML_BUTTON seemed fairly unnecessary to me as well. Still, I guess it's usually only a small number of fields where html is needed, so perhaps it's better to handle those cases individually and remove all three of these options. It might be enough to give an example in the readme how to do that exactly.
|
Can you please update the Django and django-crispy-forms requirements listed in the README: https://github.com/torchbox/tbxforms#requirements |
|
Ah, I just noticed that this was merged - sorry I couldn't address your comments, I found myself in a "client work" whirlwind these last few weeks 😔 |
|
No worries, a few other MRs have merged recently, so I'm working through a few changes (including those!) to prep a release :). Thanks for everything you've done here - it's all looking mega! |
Similar to #28 , but focused on the upgrade of the
django-crispy-formsdependency only 🙂CI passes: https://github.com/olivierphi/tbxforms/actions/runs/7447980089 ✔️