Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jinja support #247

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Jinja support #247

wants to merge 19 commits into from

Conversation

CuriousLearner
Copy link

@CuriousLearner CuriousLearner commented Jun 21, 2024 •
edited by zerolab
Loading

Description

Adds Jinja support to the django-pattern-library. It is based on @gone's work and will superseed #206.

Fixes #171 -> Discussion #180

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

gone and others added 19 commits July 31, 2023 16:10
@gone
First pass at renderers
2207b4e
@luord @gone
Moving from loading at the global level to loading at the template level
5677888
@luord @gone
Got pattern library working
0b871ff
@luord @gone
Fixed test_utils
e56da13
@luord @gone
Fixed commands
5fb5847
@edcohen08
move everything into lib
a217cfd
@edcohen08
more documentation
6aa8071
@edcohen08
no noqa
d425653
@edcohen08
reorg calling override, dont dupe
0cc7169
@edcohen08
document
a62eefb
@maribedran
Update pyproject with Django and Poetry newer versions
189f3c9
@maribedran
Fix error accessing pattern template name
626438a
@maribedran
Wrap rendered pattern HTML with mark_safe to render correctly on temp…
f6896c5 
…late
@maribedran
Merge remote-tracking branch 'torchbox/main' into jinja
351ca10
@CuriousLearner
Merge branch 'main' of https://github.com/torchbox/django-pattern-lib…
6810527 
…rary into jinja

* 'main' of https://github.com/torchbox/django-pattern-library:
  Add Python 3.12 to the test matrix, drop Django 4.1 (torchbox#242)
  Updates for version 1.2.0
  Improve handling of non-string values for 'override_tag's 'default_html' argument (torchbox#224)
  fix: make it work for django5.0 (updated) (torchbox#241)
  Upgrade GitHub Actions versions (torchbox#237)
  Fix typos discovered by codespell (torchbox#238)
@CuriousLearner
Update poetry lock file
6a73acb
@CuriousLearner
fix: linting
10b90af
@CuriousLearner
Run isort
2592c71
@mtrythall
Merge pull request #1 from lincolnloop/upgrade-jinja-django-5
13e6632 
Upgrade Jinja support to work with Django 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jinja2 support plan
6 participants
@CuriousLearner @gone @luord @edcohen08 @maribedran @mtrythall