clearState preserves structure in tables with Tensors #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self[f] = nil | ||
| local function clear(t) | ||
| if torch.isTensor(t) then | ||
| return t.new() |
There was a problem hiding this comment.
shouldn't this be t:set()? t.new() creates a new tensor.
There was a problem hiding this comment.
I think that if #673 gets merged, we will be able to just call :set() on the tensors and keep all the references to the network tensors after clearState.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clearState is used on a table with tensors, it now preserves the structure (recursively) and creates a table with empty tensors.