Skip to content

Commit

Permalink
chore: spreadsheet layout improvement (makeplane#3483)
Browse files Browse the repository at this point in the history
* chore: spreadsheet layout improvement

* chore: spreadsheet layout improvement

* chore: spreadsheet layout improvement
  • Loading branch information
anmolsinghbhatia authored Jan 27, 2024
1 parent ddae745 commit 9ecdcc6
Show file tree
Hide file tree
Showing 8 changed files with 52 additions and 2 deletions.
6 changes: 6 additions & 0 deletions web/store/issue/archived/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export class ArchivedIssuesFilter extends IssueFilterHelperStore implements IArc
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -183,6 +184,11 @@ export class ArchivedIssuesFilter extends IssueFilterHelperStore implements IArc
_filters.displayFilters.group_by = "state";
updatedDisplayFilters.group_by = "state";
}
// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
Expand Down
9 changes: 7 additions & 2 deletions web/store/issue/cycle/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export class CycleIssuesFilter extends IssueFilterHelperStore implements ICycleI
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -195,6 +196,12 @@ export class CycleIssuesFilter extends IssueFilterHelperStore implements ICycleI
updatedDisplayFilters.group_by = "state";
}

// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
set(
Expand Down Expand Up @@ -262,5 +269,3 @@ export class CycleIssuesFilter extends IssueFilterHelperStore implements ICycleI
}
};
}


7 changes: 7 additions & 0 deletions web/store/issue/draft/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export class DraftIssuesFilter extends IssueFilterHelperStore implements IDraftI
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -179,6 +180,12 @@ export class DraftIssuesFilter extends IssueFilterHelperStore implements IDraftI
updatedDisplayFilters.group_by = "state";
}

// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
set(
Expand Down
7 changes: 7 additions & 0 deletions web/store/issue/module/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export class ModuleIssuesFilter extends IssueFilterHelperStore implements IModul
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -194,6 +195,12 @@ export class ModuleIssuesFilter extends IssueFilterHelperStore implements IModul
updatedDisplayFilters.group_by = "state";
}

// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
set(
Expand Down
6 changes: 6 additions & 0 deletions web/store/issue/profile/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export class ProfileIssuesFilter extends IssueFilterHelperStore implements IProf
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -188,6 +189,11 @@ export class ProfileIssuesFilter extends IssueFilterHelperStore implements IProf
_filters.displayFilters.group_by = "priority";
updatedDisplayFilters.group_by = "priority";
}
// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
Expand Down
6 changes: 6 additions & 0 deletions web/store/issue/project-views/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export class ProjectViewIssuesFilter extends IssueFilterHelperStore implements I
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -192,6 +193,11 @@ export class ProjectViewIssuesFilter extends IssueFilterHelperStore implements I
_filters.displayFilters.group_by = "state";
updatedDisplayFilters.group_by = "state";
}
// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
Expand Down
7 changes: 7 additions & 0 deletions web/store/issue/project/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export class ProjectIssuesFilter extends IssueFilterHelperStore implements IProj
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
}
Expand Down Expand Up @@ -191,6 +192,12 @@ export class ProjectIssuesFilter extends IssueFilterHelperStore implements IProj
updatedDisplayFilters.group_by = "state";
}

// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
set(
Expand Down
6 changes: 6 additions & 0 deletions web/store/issue/workspace/filter.store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
);

if (userFilters?.displayFilters?.layout === "gantt_chart") filteredRouteParams.start_target_date = true;
if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
};
Expand Down Expand Up @@ -213,6 +214,11 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
_filters.displayFilters.group_by = "state";
updatedDisplayFilters.group_by = "state";
}
// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
Expand Down

0 comments on commit 9ecdcc6

Please sign in to comment.