Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MP-471] Add icons (Expand / Collapse / CommandKey) #4624

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Q-Man
Copy link
Contributor

@Q-Man Q-Man commented Dec 2, 2024

MP-471

Description

Add icons:

  • Expand16 / Expand24
  • Collapse16 / Collapse24
  • CommandKey16 / CommandKey24

How to test

  • yarn start:storybook
  • /?path=/story/components-icons--icons
  • search for Expand / Collapse / CommandKey and check the icon

Development checks

  • Add changeset according to guidelines (if needed)
  • n/a Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • n/a Annotate all props in component with documentation
  • n/a Create examples for component
  • n/a Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • n/a Covered with tests (visual tests included)

Breaking change

  • n/a codemod is created and showcased in the changeset
  • n/a test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@Q-Man Q-Man requested a review from a team as a code owner December 2, 2024 07:17
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 633ceff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@toptal/picasso-icons Minor
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso Patch
@toptal/picasso-accordion Patch
@toptal/picasso-account-select Patch
@toptal/picasso-alert Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-avatar Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-breadcrumbs Patch
@toptal/picasso-button Patch
@toptal/picasso-calendar Patch
@toptal/picasso-carousel Patch
@toptal/picasso-date-picker Patch
@toptal/picasso-drawer Patch
@toptal/picasso-dropzone Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-file-input Patch
@toptal/picasso-form Patch
@toptal/picasso-grid Patch
@toptal/picasso-helpbox Patch
@toptal/picasso-input Patch
@toptal/picasso-input-adornment Patch
@toptal/picasso-list Patch
@toptal/picasso-logo Patch
@toptal/picasso-menu Patch
@toptal/picasso-modal Patch
@toptal/picasso-notification Patch
@toptal/picasso-number-input Patch
@toptal/picasso-outlined-input Patch
@toptal/picasso-page Patch
@toptal/picasso-password-input Patch
@toptal/picasso-rating Patch
@toptal/picasso-section Patch
@toptal/picasso-select Patch
@toptal/picasso-show-more Patch
@toptal/picasso-step Patch
@toptal/picasso-table Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tag Patch
@toptal/picasso-timepicker Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-pagination Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-tree-view Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-checkbox Patch
@toptal/picasso-radio Patch
@toptal/picasso-switch Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-date-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Q-Man Q-Man self-assigned this Dec 2, 2024
@Q-Man Q-Man force-pushed the mp-471-picasso-icons branch from 6b87d5b to 633ceff Compare December 2, 2024 07:19
@Q-Man
Copy link
Contributor Author

Q-Man commented Dec 2, 2024

@toptal-anvil ping reviewers

Copy link
Collaborator

@denieler denieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, new icons are part of BASE Iconography 👍

Copy link
Contributor

@diogolessa diogolessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to hold the merge for a while until I confirm with designers

Copy link
Contributor

@diogolessa diogolessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed 👍🏻

@Q-Man Q-Man merged commit 41357fe into master Dec 2, 2024
17 checks passed
@Q-Man Q-Man deleted the mp-471-picasso-icons branch December 2, 2024 13:10
@toptal-build toptal-build mentioned this pull request Dec 2, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants