Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FX-5973] Update tag to span #4567

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[FX-5973] Update tag to span #4567

merged 1 commit into from
Sep 20, 2024

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Sep 19, 2024 •
edited by jira bot
Loading

FX-5973

Description

As we allow pass ReactNode to the Tag.Rectangular, users have errors when passing something else than span, because different tags cannot be rendered inside paragraph. Tag is also rendered as a span.

How to test

  • Temploy
  • FIXME: Add the steps describing how to verify your changes

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@TomasSlama TomasSlama self-assigned this Sep 19, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6ad64ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@toptal/picasso-tag Patch
@toptal/picasso Patch
@toptal/picasso-page Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/picasso-application-update-notification@2.0.20-alpha-fx-5973-tag-2bb013c55.0+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55
yarn add @toptal/[email protected]+2bb013c55

@TomasSlama TomasSlama marked this pull request as ready for review September 19, 2024 06:39
@TomasSlama TomasSlama requested a review from a team September 19, 2024 06:39
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@ruslan-sed ruslan-sed self-requested a review September 19, 2024 07:58
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@TomasSlama TomasSlama requested a review from a team September 19, 2024 12:32
@TomasSlama
Copy link
Contributor Author

@toptal-anvil ping reviewers

@TomasSlama TomasSlama enabled auto-merge (squash) September 19, 2024 17:18
@AdrianContiu AdrianContiu self-requested a review September 20, 2024 08:00
@TomasSlama TomasSlama merged commit 5287366 into master Sep 20, 2024
18 checks passed
@TomasSlama TomasSlama deleted the fx-5973-tag branch September 20, 2024 08:01
@toptal-build toptal-build mentioned this pull request Sep 20, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruslan-sed ruslan-sed ruslan-sed approved these changes

@AdrianContiu AdrianContiu AdrianContiu approved these changes

Assignees

@TomasSlama TomasSlama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomasSlama @toptal-devbot @AdrianContiu @ruslan-sed