Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query builder multiselect type #4093

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

rasitozcan
Copy link
Contributor

@rasitozcan rasitozcan commented Jan 12, 2024

[no-jira]

Description

Describe the changes and motivations for the pull request.

How to test

  • Temploy
  • Fix typing for query builder multiselect

Development checks

Breaking change

  • [N/A] codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@rasitozcan rasitozcan self-assigned this Jan 12, 2024
Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 3d5746f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-query-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rasitozcan
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-fix-qb-multiselect-type-3d5746f7e.46+3d5746f7e
yarn add @toptal/[email protected]+3d5746f7e
yarn add @toptal/[email protected]+3d5746f7e
yarn add @toptal/[email protected]+3d5746f7e
yarn add @toptal/[email protected]+3d5746f7e
yarn add @toptal/picasso-pictograms@2.0.1-alpha-fix-qb-multiselect-type-3d5746f7e.166+3d5746f7e
yarn add @toptal/picasso-provider@3.4.3-alpha-fix-qb-multiselect-type-3d5746f7e.38+3d5746f7e
yarn add @toptal/picasso-query-builder@1.4.1-alpha-fix-qb-multiselect-type-3d5746f7e.3+3d5746f7e
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-fix-qb-multiselect-type-3d5746f7e.46+3d5746f7e
yarn add @toptal/[email protected]+3d5746f7e
yarn add @toptal/picasso-tailwind@1.0.2-alpha-fix-qb-multiselect-type-3d5746f7e.26+3d5746f7e

@rasitozcan rasitozcan marked this pull request as ready for review January 12, 2024 13:18
@rasitozcan rasitozcan requested a review from a team as a code owner January 12, 2024 13:18
@rasitozcan rasitozcan requested review from a team, sashuk, dmaklygin, augustobmoura and mkrl January 12, 2024 13:18
@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Jan 12, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @rasitozcan 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@rasitozcan
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FX files (just the changeset 😄 ) looks good!

Copy link
Contributor

@toptalwadiibasmi toptalwadiibasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better.

@rasitozcan rasitozcan merged commit 06ad5e3 into master Jan 12, 2024
30 of 32 checks passed
@rasitozcan rasitozcan deleted the fix-qb-multiselect-type branch January 12, 2024 14:17
@toptal-build toptal-build mentioned this pull request Jan 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY no-jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants