-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-NULL] Revert debounce update #4090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 238b622 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sashuk
force-pushed
the
FX-NULL-revert-debounce-update
branch
from
January 12, 2024 10:11
5fc88f0
to
8138028
Compare
sashuk
force-pushed
the
FX-NULL-revert-debounce-update
branch
from
January 12, 2024 11:12
8138028
to
a0a850e
Compare
sashuk
changed the title
[FX-NULL] Revert debounce update
[FX-NULL] Revert debounce update and remove injectFirst
Jan 12, 2024
sashuk
force-pushed
the
FX-NULL-revert-debounce-update
branch
from
January 15, 2024 14:28
a0a850e
to
97f0de8
Compare
sashuk
force-pushed
the
FX-NULL-revert-debounce-update
branch
from
January 15, 2024 18:38
c39549e
to
d9920fa
Compare
sashuk
changed the title
[FX-NULL] Revert debounce update and remove injectFirst
[FX-NULL] Revert debounce update
Jan 15, 2024
sashuk
force-pushed
the
FX-NULL-revert-debounce-update
branch
from
January 18, 2024 17:25
d9920fa
to
238b622
Compare
augustobmoura
approved these changes
Jan 18, 2024
mkrl
approved these changes
Jan 18, 2024
dmaklygin
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-4727
Description
This pull request reverts
[email protected]
update (#4079), as it causes Staff Portal Cypress tests to fail with the following errorThe error is caused from latest major version of
debounce
and by sindresorhus/debounce@95eef87#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R28 in particular.How to test
Development checks
props
in component with documentationexamples
for componentPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?