Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-3043] Switch to actions/create-jira-deployment #4074

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

jcobarreto
Copy link
Contributor

@jcobarreto jcobarreto commented Jan 1, 2024

CI-3043

Description

The CI team is currently working on replacing the external-proxy with Google Identity Aware Proxy (IAP). More info here.

IAP is a Google service that allows control access to web applications running on GCP. It provides a security layer for applications by ensuring that only authenticated and authorized users/service accounts can access them. To programmatically access a resource protected by the IAP, we need to generate a JWT token and pass it alongside the request to authenticate before accessing the protected resource.

Currently, we use the jenkins-job-trigger-action to trigger Jenkins jobs from a GH workflow. Since this is a public action repo and to not expose our internal infrastructure implementation, we created the new private action (trigger-jenkins-job) to implement the IAP necessary steps for authentication and authorization. This new action requires some new inputs (secrets) used in the action’s steps to generate the authentication token.

The IAP is already enabled for our Jenkins servers in alternative URLs during the migration, that’s why we use the input jenkins_url as a secret. Its main role is to make it easier and transparent when we turn the key to enable IAP in the production’s Jenkins URLs.

In this PR, we switch to the actions/create-jira-deployment action, which uses the new trigger-jenkins-job action that implements the underlying steps to authenticate with IAP when triggering a Jenkins job from a GitHub workflow.

Review

  • Get 👍 from code review
  • Squashed related commits together
  • Removed labels that block merging (wip, do-not-merge, needs-management-approval)

@jcobarreto jcobarreto self-assigned this Jan 1, 2024
Copy link

changeset-bot bot commented Jan 1, 2024

⚠️ No Changeset found

Latest commit: 10ea56d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jcobarreto jcobarreto force-pushed the ci-switch-trigger-jenkins-job branch from 0007f7d to 61b93ed Compare January 1, 2024 17:53
@jcobarreto jcobarreto force-pushed the ci-switch-trigger-jenkins-job branch from 61b93ed to 9212162 Compare January 1, 2024 18:08
@jcobarreto jcobarreto marked this pull request as ready for review January 3, 2024 18:45
@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Jan 3, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @jcobarreto 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jcobarreto jcobarreto requested a review from a team January 4, 2024 09:46
@jcobarreto jcobarreto merged commit 536e08f into master Jan 4, 2024
28 of 30 checks passed
@jcobarreto jcobarreto deleted the ci-switch-trigger-jenkins-job branch January 4, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants