-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPT-1489] Add data-testid to ValidationErrors in QueryBuilder #4047
[CPT-1489] Add data-testid to ValidationErrors in QueryBuilder #4047
Conversation
🦋 Changeset detectedLatest commit: 43e585e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Greetings from FX team, @toptalwadiibasmi 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
packages/picasso-query-builder/src/QueryBuilder/QueryBuilder.tsx
Outdated
Show resolved
Hide resolved
packages/picasso-query-builder/src/QueryBuilder/QueryBuilder.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't forget to add changeset, otherwise it will not be released
@toptal-bot run package:alpha-release |
@toptal-bot run package:alpha-release |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
packages/picasso-query-builder/src/ValidationErrors/ValidationErrors.tsx
Outdated
Show resolved
Hide resolved
01877e6
to
43e585e
Compare
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
CPT-1489
Description
This PR introduces data test id to the validation errors component in the query builder
How to test
Screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?