Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPT-1489] Add data-testid to ValidationErrors in QueryBuilder #4047

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

toptalwadiibasmi
Copy link
Contributor

@toptalwadiibasmi toptalwadiibasmi commented Dec 5, 2023

CPT-1489

Description

This PR introduces data test id to the validation errors component in the query builder

How to test

  • Verify testIds includes validationErrors.

Screenshots

Development checks

Breaking change

  • [N/A] codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@toptalwadiibasmi toptalwadiibasmi requested a review from a team as a code owner December 5, 2023 20:54
Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 43e585e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-query-builder Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptalwadiibasmi toptalwadiibasmi self-assigned this Dec 5, 2023
@github-actions github-actions bot added the contribution DO NOT ADD MANUALLY label Dec 5, 2023
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @toptalwadiibasmi 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't forget to add changeset, otherwise it will not be released

@toptalwadiibasmi
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptalwadiibasmi toptalwadiibasmi requested a review from a team December 6, 2023 13:04
@toptalwadiibasmi
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptalwadiibasmi
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.13+01877e68a
yarn add @toptal/picasso@42.1.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.11+01877e68a
yarn add @toptal/picasso-charts@56.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.13+01877e68a
yarn add @toptal/picasso-codemod@5.6.4-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.63+01877e68a
yarn add @toptal/picasso-forms@66.1.2-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.8+01877e68a
yarn add @toptal/picasso-pictograms@2.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.133+01877e68a
yarn add @toptal/picasso-provider@3.4.3-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.5+01877e68a
yarn add @toptal/picasso-query-builder@1.1.3-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.44+01877e68a
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.13+01877e68a
yarn add @toptal/picasso-shared@13.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.133+01877e68a
yarn add @toptal/picasso-tailwind@1.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-01877e68a.37+01877e68a

@rasitozcan rasitozcan force-pushed the CPT-1489-fe-add-test-id-for-validation-errors branch from 01877e6 to 43e585e Compare December 7, 2023 14:36
@rasitozcan
Copy link
Contributor

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.16+43e585e00
yarn add @toptal/picasso@42.1.2-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.6+43e585e00
yarn add @toptal/picasso-charts@56.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.16+43e585e00
yarn add @toptal/picasso-codemod@5.6.4-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.66+43e585e00
yarn add @toptal/picasso-forms@66.1.2-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.11+43e585e00
yarn add @toptal/picasso-pictograms@2.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.136+43e585e00
yarn add @toptal/picasso-provider@3.4.3-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.8+43e585e00
yarn add @toptal/picasso-query-builder@1.1.3-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.47+43e585e00
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.16+43e585e00
yarn add @toptal/picasso-shared@13.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.136+43e585e00
yarn add @toptal/picasso-tailwind@1.0.1-alpha-CPT-1489-fe-add-test-id-for-validation-errors-43e585e00.40+43e585e00

@rasitozcan rasitozcan merged commit 43a6e5a into master Dec 7, 2023
14 of 16 checks passed
@rasitozcan rasitozcan deleted the CPT-1489-fe-add-test-id-for-validation-errors branch December 7, 2023 14:55
@toptal-build toptal-build mentioned this pull request Dec 7, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants