Update rubocop to latest and fix as many violations as possible #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstrzebinczyk
force-pushed
the
devx-4047-bump-rubocop
branch
from
4c9ccb2 to
91c32ab
Compare
|
@toptal-anvil ping reviewers |
kml
approved these changes
May 13, 2024
id-ilych
reviewed
May 13, 2024
lstrzebinczyk
force-pushed
the
devx-4047-bump-rubocop
branch
2 times, most recently
from
5bc554c to
353a7fe
Compare
lstrzebinczyk
force-pushed
the
devx-4047-bump-rubocop
branch
from
353a7fe to
5f0c343
Compare
Co-authored-by: Ilya Denisov <[email protected]>
Co-authored-by: Ilya Denisov <[email protected]>
…pec.rb Co-authored-by: Ilya Denisov <[email protected]>
…pec.rb Co-authored-by: Ilya Denisov <[email protected]>
…ny_spec.rb Co-authored-by: Ilya Denisov <[email protected]>
Co-authored-by: Ilya Denisov <[email protected]>
Co-authored-by: Ilya Denisov <[email protected]>
Co-authored-by: Ilya Denisov <[email protected]>
Co-authored-by: Ilya Denisov <[email protected]>
…rm into devx-4047-bump-rubocop
id-ilych
approved these changes
May 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title. We were able to fix about 1000 violations in automated manner, I manually fixed a bunch others, but hundreds of violations remain. I created a todo file to cut the work at where it's right now.
granite-form codebase is in a poor shape.
AC: