Remove localized (#21)

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * Drop support for taking `model` as first argument in default/readonly/enum/normalize. This means that `default: -> (model) { model.other_field}` is no longer supported and should be replaced with `default: -> { other_field }`.
 * Add support for evaluating `Symbol` for readonly/enum/normalize. If symbol is passed in one of those options, method with that name will be called when evaluating the value.
+* Remove `localized` attribute type.
 
 ## v0.3.0
 

README.md

@@ -252,14 +252,6 @@ end
 
 The keys list might be restricted with the `:keys` option. Default and enum modifiers are applied on each value, normalizers are applied on the hash.
 
-#### Localized
-
-`localized` is similar to how `Globalize 3` attributes work.
-
-```ruby
-localized :title, String
-```
-
 #### Represents
 
 `represents` provides an easy way to expose model attributes through an interface.

lib/granite/form/model.rb

@@ -5,7 +5,6 @@
 require 'granite/form/model/primary'
 require 'granite/form/model/persistence'
 require 'granite/form/model/associations'
-require 'granite/form/model/localization'
 require 'granite/form/model/representation'
 require 'granite/form/model/dirty'
 

spec/granite/form/model/attributes_spec.rb

@@ -4,15 +4,11 @@
   let(:model) do
     stub_model do
       include Granite::Form::Model::Associations
-      include Granite::Form::Model::Localization
 
       attribute :id, Integer
       attribute :full_name, String
       alias_attribute :name, :full_name
 
-      localized :t, String
-      alias_attribute :title, :t
-
       embeds_one(:author) {}
       embeds_many(:projects) {}
     end
@@ -34,8 +30,8 @@
 
   describe '.attribute_names' do
     specify { expect(stub_model.attribute_names).to eq([]) }
-    specify { expect(model.attribute_names).to eq(%w[id full_name t author projects]) }
-    specify { expect(model.attribute_names(false)).to eq(%w[id full_name t]) }
+    specify { expect(model.attribute_names).to eq(%w[id full_name author projects]) }
+    specify { expect(model.attribute_names(false)).to eq(%w[id full_name]) }
   end
 
   describe '.inspect' do
@@ -100,8 +96,8 @@
 
   describe '#attribute_names' do
     specify { expect(stub_model.new.attribute_names).to eq([]) }
-    specify { expect(model.new.attribute_names).to eq(%w[id full_name t author projects]) }
-    specify { expect(model.new.attribute_names(false)).to eq(%w[id full_name t]) }
+    specify { expect(model.new.attribute_names).to eq(%w[id full_name author projects]) }
+    specify { expect(model.new.attribute_names(false)).to eq(%w[id full_name]) }
   end
 
   describe '#attribute_present?' do
@@ -114,11 +110,11 @@
     specify { expect(stub_model.new.attributes).to eq({}) }
     specify do
       expect(model.new(name: 'Name').attributes)
-        .to match('id' => nil, 'full_name' => 'Name', 't' => {}, 'author' => nil, 'projects' => nil)
+        .to match('id' => nil, 'full_name' => 'Name', 'author' => nil, 'projects' => nil)
     end
     specify do
       expect(model.new(name: 'Name').attributes(false))
-        .to match('id' => nil, 'full_name' => 'Name', 't' => {})
+        .to match('id' => nil, 'full_name' => 'Name')
     end
   end
 

spec/granite/form/model/dirty_spec.rb

@@ -5,7 +5,6 @@
     stub_class(:author, ActiveRecord::Base) {}
     stub_model :premodel do
       include Granite::Form::Model::Persistence
-      include Granite::Form::Model::Localization
       include Granite::Form::Model::Associations
 
       attribute :age, Integer, default: 33
@@ -22,7 +21,6 @@
       attribute :name, String
       alias_attribute :n, :name
       collection :numbers, Integer
-      localized :title, String
     end
   end
 
@@ -70,10 +68,6 @@
   specify { expect(Model.new(a: '42').tap { |m| m.update(a: '43') }.changes).to eq('age' => [33, 43]) }
   specify { expect(Model.new(numbers: '42').changes).to eq('numbers' => [[], [42]]) }
 
-  # Have no idea how should it work right now
-  specify { expect(Model.new(title: 'Hello').changes).to eq('title' => [nil, 'Hello']) }
-  specify { expect(Model.new(title_translations: {en: 'Hello'}).changes).to eq('title' => [nil, 'Hello']) }
-
   specify { expect(Model.new).not_to respond_to :something_changed? }
   specify { expect(Model.new).to respond_to :n_changed? }