Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GE-1029] Fix GHA Node deprecation warnings in build-push-image action #335

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

MarianoSalerno
Copy link
Contributor

@MarianoSalerno MarianoSalerno commented Jun 27, 2024

GE-1029

Description

We are updating the ssh-agent action version on the build-push-image action, as it's using Node 12

How to test

  • You can see the action working, without the deprecation warning, in this run

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@MarianoSalerno MarianoSalerno self-assigned this Jun 27, 2024
Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 5bd2244

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MarianoSalerno MarianoSalerno force-pushed the GE-1029-fix-node-deprecation-warnings branch from 113ed5a to 158e931 Compare June 28, 2024 14:24
@MarianoSalerno MarianoSalerno marked this pull request as ready for review June 28, 2024 14:25
@MarianoSalerno MarianoSalerno requested a review from a team as a code owner June 28, 2024 14:25
@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Jun 28, 2024
@toptal-devbot
Copy link

Greetings from FX team, @MarianoSalerno 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@MarianoSalerno MarianoSalerno merged commit c380f36 into master Jul 1, 2024
6 checks passed
@MarianoSalerno MarianoSalerno deleted the GE-1029-fix-node-deprecation-warnings branch July 1, 2024 18:08
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants