feat: exposes additional worker configuration parameters #268
Conversation
| @@ -74,13 +74,14 @@ redis = { version = "*", optional = true } | |||
| saq = { version = "^0.9.1", optional = true } | |||
| sentry-sdk = { version = "*", optional = true } | |||
| sqlalchemy = { version = "==2.0.0rc3", optional = true } | |||
| greenlet = {version = "*", platform = "darwin", optional = true } | |||
There was a problem hiding this comment.
Is this for this?
There was a problem hiding this comment.
It is, I didn't think to look for an open issue on this.
There was a problem hiding this comment.
I wonder if the issue is arm64 in general, or just M1?
There was a problem hiding this comment.
I believe this is going to be an M1/OSX only specific issue. I'd bet that the x86 OSX laptops probably do not have this issue. Is there a way to specify architecture as well?
There was a problem hiding this comment.
I don't know - we are considering moving our workloads onto https://aws.amazon.com/ec2/graviton/ - so I might just spin one up and see if it gets the same treatment as m1
| class CronJob(saq.CronJob): | ||
| """Cron Job.""" |
There was a problem hiding this comment.
It's main purpose now is for for convenience. (i.e. you can import all of the classes from worker instead of having to import from saq as well). I thought I might need to add additional functionality there, but I'm not sure at this point.
This enhancement exposes the following parameters on the
create_worker_instance:concurrency(also added tosettings.WorkerSettings.CONCURRENCY)cron_jobsstartupshutdown