Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch tce-lib action to spawn tasks #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Freyskeyd
Copy link
Member

Description

This PR moves some part of code that can be placed in future into tokio tasks in order to check for performance gain.

PR Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@Freyskeyd Freyskeyd requested a review from a team as a code owner March 25, 2024 07:22
@Freyskeyd Freyskeyd force-pushed the debug/move-pending-exec-to-task branch 3 times, most recently from e81d338 to 0ffd222 Compare March 26, 2024 19:12
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 55.24476% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 72.23%. Comparing base (b8cd730) to head (6658f78).

Files Patch % Lines
crates/topos-tce/src/app_context/api.rs 38.88% 33 Missing ⚠️
crates/topos-tce/src/app_context/network.rs 43.47% 26 Missing ⚠️
crates/topos-tce/src/app_context/protocol.rs 88.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   72.21%   72.23%   +0.02%     
==========================================
  Files         219      219              
  Lines       12829    12842      +13     
==========================================
+ Hits         9265     9277      +12     
- Misses       3564     3565       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Freyskeyd Freyskeyd force-pushed the debug/move-pending-exec-to-task branch 4 times, most recently from d695440 to 7e71ea4 Compare March 29, 2024 09:08
@Freyskeyd Freyskeyd force-pushed the debug/move-pending-exec-to-task branch from 7e71ea4 to 6658f78 Compare March 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants