Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge topos-smart-contracts into topos #475

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Conversation

JDawg287
Copy link
Member

@JDawg287 JDawg287 commented Mar 12, 2024

Description

This PR merges the topos-smart-contracts repo into topos to reduce the friction between the two. Currently, the certificate producer, formerly known as the sequencer, relies on the topos-smart-contracts as a dependency, to push and pull the certificates from the subnets.

Fixes TP-888

Additions and Changes

  • Added the topos-smart-contracts to the ./contracts dir
  • Added and modified the GitHub workflows for the contracts
  • Added prefix to the GitHub workflows to differentiate between the Contracts workflows and the Topos workflows
  • Removed Docker build and push for the contracts as the contracts are available in the topos image directly
  • Changed the dependency link for the topos-sequencer-subnet-client to the local ./contracts path

Features and implication

  • Added a build script for the topos-sequencer-subnet-client component:
    • The script runs if there is any change in the ./contracts directory
    • The script also offers an optional flag to skip the compilation of the contracts
      Note: the build script requires installation of Node.js on the system as a prerequisite
  • The topos Docker image contains the necessary contract artifacts
    • Added an initial stage in the Dockerfile to build the contract artifacts - this approach is the least invasive for the current production Docker image

PR Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added or updated tests that comprehensively prove my change is effective or that my feature works

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.23%. Comparing base (642203c) to head (10754d0).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/topos-sequencer-subnet-client/build.rs 74.28% 9 Missing ⚠️
...pos-sequencer-subnet-client/src/subnet_contract.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #475      +/-   ##
==========================================
+ Coverage   71.91%   72.23%   +0.31%     
==========================================
  Files         227      220       -7     
  Lines       12745    12863     +118     
==========================================
+ Hits         9166     9291     +125     
+ Misses       3579     3572       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jawad Tariq <[email protected]>
Signed-off-by: Jawad Tariq <[email protected]>
@JDawg287 JDawg287 force-pushed the feat/TP-888 branch 3 times, most recently from 32130e9 to ab4a97d Compare March 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants