Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

chore: Rename Sequencer –> Certificate Producer #457

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Feb 16, 2024

Renaming the Sequencer to Certificate Producer in the whole repo.

@dvdplm dvdplm changed the title Rename Sequencer –> Certificate Producer chore: Rename Sequencer –> Certificate Producer Feb 16, 2024
@dvdplm dvdplm marked this pull request as ready for review March 6, 2024 16:54
@dvdplm dvdplm requested a review from a team as a code owner March 6, 2024 16:54
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 11.88119% with 89 lines in your changes are missing coverage. Please review.

Project coverage is 72.15%. Comparing base (b8cd730) to head (6a32802).

Files Patch % Lines
...s-certificate-producer-subnet-runtime/src/proxy.rs 0.00% 40 Missing ⚠️
crates/topos-certificate-producer/src/lib.rs 0.00% 23 Missing ⚠️
crates/topos-node/src/process.rs 0.00% 10 Missing ⚠️
...ates/topos-certificate-producer/src/app_context.rs 0.00% 7 Missing ⚠️
crates/topos-node/src/lib.rs 12.50% 7 Missing ⚠️
crates/topos-config/src/certificate_producer.rs 75.00% 1 Missing ⚠️
crates/topos-tce-proxy/src/client.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #457       +/-   ##
=========================================
+ Coverage      0   72.15%   +72.15%     
=========================================
  Files         0      219      +219     
  Lines         0    12840    +12840     
=========================================
+ Hits          0     9265     +9265     
- Misses        0     3575     +3575     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atanmarko
Copy link
Member

atanmarko commented Mar 7, 2024

How did this happen?

# This is the 1st commit message:

chore: merge conflicts

# This is the commit message #2:

chore: rename seq to cert producer

# This is the commit message #3:

chore: rename seq to cert producer

# This is the commit message #4:

fix: use kebab case for node roles

# This is the commit message #5:

chore: comment on e2e-test files

# This is the commit message #6:

Update named file in other repo
@atanmarko
Copy link
Member

@dvdplm I would prefer cert-producer instead of certificate-producer. It looks a bit unwieldy in the crate name topos-certificate-producer-subnet-runtime

@dvdplm
Copy link
Contributor Author

dvdplm commented Mar 27, 2024

I would prefer cert-producer instead of certificate-producer. It looks a bit unwieldy in the crate name topos-certificate-producer-subnet-runtime

I agree that the name is unwieldy. I would not mind settling on cert-producer. @hadjiszs What do you say?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants