This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: bootstrapping task-manager through feature flags #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 52.99% 52.56% -0.44%
==========================================
Files 207 203 -4
Lines 9978 9803 -175
==========================================
- Hits 5288 5153 -135
+ Misses 4690 4650 -40
|
gruberb
changed the title
chore: adding task-manager feature flags
chore: adding task-manager and feature flags
Jul 21, 2023
gruberb
changed the title
chore: adding task-manager and feature flags
chore: bootstrapping task-manager through feature flags
Jul 21, 2023
Freyskeyd
reviewed
Jul 25, 2023
Signed-off-by: Simon Paitrault <[email protected]>
gruberb
commented
Jul 25, 2023
gruberb
commented
Jul 25, 2023
Freyskeyd
reviewed
Jul 26, 2023
Freyskeyd
approved these changes
Jul 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
TaskManager
to the codebase. It is an in-between step, whereas we can benchmark two different implementations of theTaskManager
task-manager-futures
: UsingFuturesUnordered
for tasks to remove themselves after being done.task-manager-channel
: To send a message to theTaskManager
and removing them by hand.Fixes TP-644
Additions and Changes
Feature flag
task-manager-channels
to build and run the codebase with the channels implementation instead of the futures one.task-manager-futures
runs by default and gets deactivated when using the features flagtask-manager-channels
.New feature (non-breaking change which adds functionality)
Splitting the work of the
double_echo
intotasks
, and let them run in parallel.PR Checklist: