fix: fixing wrong use of IntCounterVec (#442)

Signed-off-by: Simon Paitrault <[email protected]>

crates/topos-metrics/src/lib.rs

@@ -11,6 +11,9 @@ mod double_echo;
 mod p2p;
 mod storage;
 
+#[cfg(test)]
+mod tests;
+
 pub use api::*;
 pub use double_echo::*;
 pub use p2p::*;

crates/topos-metrics/src/p2p.rs

@@ -61,15 +61,15 @@ lazy_static! {
         register_int_counter_vec_with_registry!(
             "p2p_message_deserialize_failure_total",
             "Number of message deserialization failure.",
-            &["echo", "ready", "gossip"],
+            &["topic"],
             TOPOS_METRIC_REGISTRY
         )
         .unwrap();
     pub static ref P2P_MESSAGE_SERIALIZE_FAILURE_TOTAL: IntCounterVec =
         register_int_counter_vec_with_registry!(
             "p2p_message_serialize_failure_total",
             "Number of message serialization failure.",
-            &["echo", "ready", "gossip"],
+            &["topic"],
             TOPOS_METRIC_REGISTRY
         )
         .unwrap();

crates/topos-metrics/src/tests.rs

@@ -0,0 +1,21 @@
+use crate::p2p;
+
+#[test]
+fn increment_echo_failure_ser() {
+    let m = &p2p::P2P_MESSAGE_SERIALIZE_FAILURE_TOTAL;
+
+    m.with_label_values(&["echo"]).inc();
+
+    assert_eq!(m.get_metric_with_label_values(&["echo"]).unwrap().get(), 1);
+    assert_eq!(m.get_metric_with_label_values(&["ready"]).unwrap().get(), 0);
+}
+
+#[test]
+fn increment_echo_failure_des() {
+    let m = &p2p::P2P_MESSAGE_DESERIALIZE_FAILURE_TOTAL;
+
+    m.with_label_values(&["echo"]).inc();
+
+    assert_eq!(m.get_metric_with_label_values(&["echo"]).unwrap().get(), 1);
+    assert_eq!(m.get_metric_with_label_values(&["ready"]).unwrap().get(), 0);
+}