Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Don't panic with invalid ThresholdParameters (#38) #202

Don't panic with invalid ThresholdParameters (#38)

Don't panic with invalid ThresholdParameters (#38) #202

Triggered via push April 11, 2024 05:47
Status Failure
Total duration 1m 7s
Artifacts

ci.yml

on: push
Matrix: Bitrot check
Matrix: build
Matrix: test
Matrix: test_no_std
Fit to window
Zoom out
Zoom in

Annotations

17 errors and 36 warnings
mismatched types: tests/ice_frost.rs#L385
error[E0308]: mismatched types --> tests/ice_frost.rs:385:51 | 385 | let mut aggregator = SignatureAggregator::new(threshold_parameters, frost_pk, &message[..]); | ------------------------ ^^^^^^^^^^^^^^^^^^^^ expected `ThresholdParameters<Secp256k1Sha256>`, found `Result<ThresholdParameters<_>, ...>` | | | arguments to this function are incorrect | = note: expected struct `ice_frost::parameters::ThresholdParameters<ice_frost::testing::Secp256k1Sha256>` found enum `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` note: associated function defined here --> /home/runner/work/ice-frost/ice-frost/src/sign/signature.rs:425:12 | 425 | pub fn new( | ^^^ help: consider using `Result::expect` to unwrap the `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` value, panicking if the value is a `Result::Err` | 385 | let mut aggregator = SignatureAggregator::new(threshold_parameters.expect("REASON"), frost_pk, &message[..]); | +++++++++++++++++
mismatched types: tests/ice_frost.rs#L331
error[E0308]: mismatched types --> tests/ice_frost.rs:331:17 | 330 | DistributedKeyGeneration::<RoundOne, Secp256k1Sha256>::new( | ---------------------------------------------------------- arguments to this function are incorrect 331 | simulated_parameters, | ^^^^^^^^^^^^^^^^^^^^ expected `ThresholdParameters<Secp256k1Sha256>`, found `Result<ThresholdParameters<_>, ...>` | = note: expected struct `ice_frost::parameters::ThresholdParameters<ice_frost::testing::Secp256k1Sha256>` found enum `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` note: associated function defined here --> /home/runner/work/ice-frost/ice-frost/src/dkg/key_generation.rs:684:12 | 684 | pub fn new( | ^^^ help: consider using `Result::expect` to unwrap the `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` value, panicking if the value is a `Result::Err` | 331 | simulated_parameters.expect("REASON"), | +++++++++++++++++
mismatched types: tests/ice_frost.rs#L326
error[E0308]: mismatched types --> tests/ice_frost.rs:326:30 | 326 | Participant::reshare(threshold_parameters, &frost_sk, &signers, rng).unwrap(); | -------------------- ^^^^^^^^^^^^^^^^^^^^ expected `ThresholdParameters<Secp256k1Sha256>`, found `Result<ThresholdParameters<_>, ...>` | | | arguments to this function are incorrect | = note: expected struct `ice_frost::parameters::ThresholdParameters<ice_frost::testing::Secp256k1Sha256>` found enum `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` note: associated function defined here --> /home/runner/work/ice-frost/ice-frost/src/dkg/participant.rs:244:12 | 244 | pub fn reshare( | ^^^^^^^ help: consider using `Result::expect` to unwrap the `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` value, panicking if the value is a `Result::Err` | 326 | Participant::reshare(threshold_parameters.expect("REASON"), &frost_sk, &signers, rng).unwrap(); | +++++++++++++++++
mismatched types: tests/ice_frost.rs#L313
error[E0308]: mismatched types --> tests/ice_frost.rs:313:56 | 313 | Participant::<Secp256k1Sha256>::new_signer(threshold_parameters, i, rng).unwrap(); | ------------------------------------------ ^^^^^^^^^^^^^^^^^^^^ expected `ThresholdParameters<Secp256k1Sha256>`, found `Result<ThresholdParameters<_>, ...>` | | | arguments to this function are incorrect | = note: expected struct `ice_frost::parameters::ThresholdParameters<ice_frost::testing::Secp256k1Sha256>` found enum `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` note: associated function defined here --> /home/runner/work/ice-frost/ice-frost/src/dkg/participant.rs:118:12 | 118 | pub fn new_signer( | ^^^^^^^^^^ help: consider using `Result::expect` to unwrap the `std::result::Result<ice_frost::parameters::ThresholdParameters<_>, ice_frost::Error<_>>` value, panicking if the value is a `Result::Err` | 313 | Participant::<Secp256k1Sha256>::new_signer(threshold_parameters.expect("REASON"), i, rng).unwrap(); | +++++++++++++++++
Clippy
Clippy had exited with the 101 exit code
Test on ubuntu-latest: tests/ice_frost.rs#L313
mismatched types
Test on ubuntu-latest: tests/ice_frost.rs#L326
mismatched types
Test on ubuntu-latest: tests/ice_frost.rs#L331
mismatched types
Test on ubuntu-latest: tests/ice_frost.rs#L385
mismatched types
Test on ubuntu-latest
could not compile `ice-frost` (test "ice_frost") due to 4 previous errors
Test on ubuntu-latest
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Test on ubuntu-latest (no-std)
could not compile `ice-frost` (test "ice_frost") due to 4 previous errors
Test on ubuntu-latest (no-std)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build target wasm32-unknown-unknown
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check (stable, ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Bitrot check (stable, ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest (no-std)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test on ubuntu-latest (no-std)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/