Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
In$2048$ x $2048$ x $1024$ , a problem would arise, as the computed number needed a
edgeToPosition
of both Implicit and Periodic Triangulations, an intermediary variable (e
) was set and was an integer. This worked only up until a certain number of edges.For a grid of
long int
type to be expressed and was expressed as anint
. The result was negative integer positions (impossible in our grids).Setting the
int
as attk::SimplexId
solves the problem.For
triangleToPosition
, the variable (heret
) is already attk::SimplexId
.Thanks for any feedback.