Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPI] Fix int to SimplexId #1070

Merged

Conversation

eve-le-guillou
Copy link
Contributor

Hi all,

In edgeToPosition of both Implicit and Periodic Triangulations, an intermediary variable (e) was set and was an integer. This worked only up until a certain number of edges.
For a grid of $2048$ x $2048$ x $1024$, a problem would arise, as the computed number needed a long int type to be expressed and was expressed as an int. The result was negative integer positions (impossible in our grids).

Setting theint as a ttk::SimplexId solves the problem.

For triangleToPosition, the variable (here t) is already a ttk::SimplexId.

Thanks for any feedback.

@julien-tierny
Copy link
Collaborator

looks good to me, thanks a lot!

@julien-tierny julien-tierny merged commit fac0085 into topology-tool-kit:dev Oct 1, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants