Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading check_code workflow to pv513 #1060

Merged
merged 9 commits into from
Sep 17, 2024
9 changes: 5 additions & 4 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:
cancel-in-progress: true

env:
PV_TAG: v5.12.0-headless
PV_TAG: v5.13.0-headless
PV_REPO: topology-tool-kit/ttk-paraview


Expand All @@ -35,7 +35,7 @@ jobs:
check-formatting:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install latest clang-format
run: |
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
CMAKE_EXPORT_COMPILE_COMMANDS: ON

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install Ubuntu dependencies
run: |
Expand Down Expand Up @@ -161,6 +161,7 @@ jobs:

- name: Check Doxygen documentation warnings
if: matrix.config.dox
continue-on-error: true
run: |
cd build
! cmake --build . --target doc |& grep warning
Expand All @@ -182,7 +183,7 @@ jobs:
CMAKE_EXPORT_COMPILE_COMMANDS: ON

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install Ubuntu dependencies
run: |
Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ jobs:
run: |
sudo apt install ./ttk-paraview-headless.deb

# TODO: more aggressive warnings? (ubuntu-24.04)
- name: Create & configure TTK build directory
run: |
mkdir build
Expand Down Expand Up @@ -210,6 +209,8 @@ jobs:
# remove buggy example
# related issue: https://github.com/topology-tool-kit/ttk/issues/1055
rm ttk-data/states/nestedTrackingFromOverlap.py
# remove examples which fill up the memory
rm ttk-data/states/topologicalOptimization_darkSky.pvsm

cd ttk-data/tests
mkdir output_screenshots
Expand Down Expand Up @@ -241,6 +242,8 @@ jobs:
# remove buggy example
# related issue: https://github.com/topology-tool-kit/ttk/issues/1055
rm python/nestedTrackingFromOverlap.py
# remove examples which fill up the memory
rm python/topologicalOptimization_darkSky.py
python3 -u python/run.py

- name: Test ttk-data Python scripts results [NOT ENFORCED]
Expand Down Expand Up @@ -373,6 +376,8 @@ jobs:
# remove buggy example
# related issue: https://github.com/topology-tool-kit/ttk/issues/1055
rm ttk-data/states/nestedTrackingFromOverlap.py
# remove examples which fill up the memory
rm ttk-data/states/topologicalOptimization_darkSky.pvsm
cd ttk-data/tests
mkdir output_screenshots
pvpython -u validate.py || (tar zcf screenshots.tar.gz output_screenshots && false)
Expand All @@ -393,6 +398,8 @@ jobs:
# remove buggy example
# related issue: https://github.com/topology-tool-kit/ttk/issues/1055
rm python/nestedTrackingFromOverlap.py
# remove examples which fill up the memory
rm python/topologicalOptimization_darkSky.py
pvpython -u python/run.py
env:
PV_PLUGIN_PATH: /usr/local/bin/plugins/TopologyToolKit
Expand Down Expand Up @@ -575,6 +582,8 @@ jobs:
set PV_PLUGIN_PATH=%TTK_DIR%\bin\plugins
cd ttk-data
rm python/nestedTrackingFromOverlap.py
# remove examples which fill up the memory
rm python/topologicalOptimization_darkSky.py
pvpython.exe -u python\run.py

- name: Test ttk-data Python scripts results [NOT ENFORCED]
Expand Down
3 changes: 3 additions & 0 deletions core/vtk/ttkMorseSmaleComplex/ttkMorseSmaleComplex.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@
/// href="https://topology-tool-kit.github.io/examples/tectonicPuzzle/">Tectonic
/// Puzzle example</a> \n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/topologicalOptimization_darkSky//">Topological
/// Optimization DarkSky</a>\n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/tribute/">Tribute
/// example</a> \n
///
Expand Down
3 changes: 3 additions & 0 deletions core/vtk/ttkPersistenceDiagram/ttkPersistenceDiagram.h
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@
/// href="https://topology-tool-kit.github.io/examples/tectonicPuzzle/">Tectonic
/// Puzzle example</a> \n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/topologicalOptimization_darkSky//">Topological
/// Optimization DarkSky</a>\n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/tribute/">Tribute
/// example</a> \n
/// - <a
Expand Down
3 changes: 3 additions & 0 deletions core/vtk/ttkScalarFieldSmoother/ttkScalarFieldSmoother.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@
/// - <a
/// href="https://topology-tool-kit.github.io/examples/persistentGenerators_darkSky/">Persistent
/// Generators Dark Sky example</a> \n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/topologicalOptimization_darkSky//">Topological
/// Optimization DarkSky</a>\n

#pragma once

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@
/// href="https://topology-tool-kit.github.io/examples/tectonicPuzzle/">Tectonic
/// Puzzle example</a> \n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/topologicalOptimization_darkSky//">Topological
/// Optimization DarkSky</a>\n
/// - <a
/// href="https://topology-tool-kit.github.io/examples/tribute/">Tribute
/// example</a> \n
/// - <a
Expand Down
Loading