feat(PM-1173): Notify all copilots on copilot opportunity #815

hentrymartin · 2025-06-02T14:49:47Z

What's in this PR?

Notify all copilots on copilot opportunity

github-actions · 2025-06-02T14:50:05Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +53,12 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then((opportunity) => {
+                console.log(opportunity);


Avoid using console.log for debugging in production code. Consider using a logging library to handle logs appropriately.

github-actions · 2025-06-02T14:50:05Z

src/routes/copilotRequest/approveRequest.service.js

+              .then((opportunity) => {
+                console.log(opportunity);
+                const roles = util.getRolesByRoleName('copilot');
+                console.log(roles, 'roles by copilot');


Remove console.log statements before merging to ensure cleaner code and avoid exposing potentially sensitive information.

github-actions · 2025-06-02T14:50:08Z

src/util.js

@@ -815,6 +815,27 @@ const projectServiceUtils = {
    }
  },

+  getRolesByRoleName: Promise.coroutine(function* (roleName, logger, requestId) { // eslint-disable-line func-names


Consider using async/await instead of Promise.coroutine for better readability and modern syntax.

github-actions · 2025-06-02T14:50:08Z

src/util.js

+        return _.get(res, 'data.result.content', []).map(r => r.roleName);
+      });
+    } catch (err) {
+      return Promise.reject(err);


Instead of catching the error and returning a rejected promise, consider allowing the error to propagate naturally. This will make the function easier to handle with async/await syntax.

github-actions · 2025-06-02T15:05:06Z

src/routes/copilotRequest/approveRequest.service.js

+              .then((opportunity) => {
+                console.log(opportunity);
+                const roles = util.getRolesByRoleName('copilot');
+                const roleInfo = util.getRoleInfo(roles[0]);


Consider checking if roles is not empty before accessing roles[0] to avoid potential runtime errors.

github-actions · 2025-06-02T15:05:11Z

src/util.js

@@ -815,6 +815,48 @@ const projectServiceUtils = {
    }
  },

+  getRoleInfo: Promise.coroutine(function* (roleId, logger, requestId) { // eslint-disable-line func-names


Consider using async/await syntax instead of Promise.coroutine for better readability and modern JavaScript practices.

github-actions · 2025-06-02T15:05:11Z

src/util.js

+        },
+      }).then((res) => {
+        logger.debug(`Role info by ${roleId}: ${JSON.stringify(res.data.result.content)}`);
+        return _.get(res, 'data.result.content', []);


The use of _.get is good for safely accessing nested properties, but ensure that lodash is imported as _ at the top of the file if not already done.

github-actions · 2025-06-02T15:05:11Z

src/util.js

+        return _.get(res, 'data.result.content', []);
+      });
+    } catch (err) {
+      return Promise.reject(err);


Instead of returning Promise.reject(err), consider using throw err; to maintain consistency with async/await error handling patterns.

github-actions · 2025-06-02T15:05:14Z

src/util.js

+        },
+      }).then((res) => {
+        logger.debug(`Roles by ${roleName}: ${JSON.stringify(res.data.result.content)}`);
+        return _.get(res, 'data.result.content', []).map(r => r.id);


The change from r.roleName to r.id alters the data being returned by the map function. Ensure that this change aligns with the intended functionality and that any dependent code is updated accordingly to handle the new data structure.

github-actions · 2025-06-02T20:54:59Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +53,14 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then(async (opportunity) => {


Consider removing the console.log(opportunity); statement if it's not needed for debugging purposes. Leaving console logs in production code can lead to performance issues and cluttered logs.

github-actions · 2025-06-02T20:54:59Z

src/routes/copilotRequest/approveRequest.service.js

+                console.log(opportunity);
+                const roles = await util.getRolesByRoleName('copilot');
+                const roleInfo = await util.getRoleInfo(roles[0]);
+                console.log(roles, roleInfo, 'roles by copilot');


Consider removing the console.log(roles, roleInfo, 'roles by copilot'); statement if it's not necessary for debugging. Console logs can clutter the output and should be avoided in production code.

github-actions · 2025-06-02T21:42:23Z

src/routes/copilotRequest/approveRequest.js

@@ -35,7 +35,7 @@ module.exports = [
      updatedBy: req.authUser.userId,
    });

-    return approveRequest(data)
+    return approveRequest(req, data)


The approveRequest function signature has changed to include req as a parameter. Ensure that the approveRequest function is updated to handle this new parameter correctly. If req is not needed in the function, consider removing it to maintain the original function signature.

github-actions · 2025-06-02T21:42:25Z

src/routes/copilotRequest/approveRequest.service.js

@@ -11,7 +12,7 @@ const resolveTransaction = (transaction, callback) => {
  return models.sequelize.transaction(callback);
 };

-module.exports = (data, existingTransaction) => {
+module.exports = (req, data, existingTransaction) => {


The function signature has been changed to include req as a parameter. Ensure that req is used appropriately within the function. If req is not used, consider removing it to avoid confusion.

github-actions · 2025-06-02T21:42:27Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +53,14 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then(async (opportunity) => {
+                console.log(opportunity);
+                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);


The function getRolesByRoleName now takes additional parameters req.log and req.id. Ensure that req is defined and available in this context to avoid potential runtime errors.

github-actions · 2025-06-02T21:42:27Z

src/routes/copilotRequest/approveRequest.service.js

+              .then(async (opportunity) => {
+                console.log(opportunity);
+                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);
+                const roleInfo = await util.getRoleInfo(roles[0], req.log, req.id);


Similarly, the function getRoleInfo now takes additional parameters req.log and req.id. Verify that req is correctly passed and accessible here to prevent any issues.

github-actions · 2025-06-02T21:42:30Z

src/routes/copilotRequest/create.js

@@ -98,7 +98,7 @@ module.exports = [
              updatedBy: req.authUser.userId,
              type: copilotRequest.data.projectType,
            });
-            return approveRequest(approveData, transaction).then(() => copilotRequest);
+            return approveRequest(req, approveData, transaction).then(() => copilotRequest);


The approveRequest function signature has changed to include req as an additional parameter. Ensure that the approveRequest function is updated accordingly to handle this new parameter, and verify that all calls to approveRequest throughout the codebase are updated to match this new signature.

github-actions · 2025-06-02T22:46:53Z

src/routes/copilotRequest/approveRequest.service.js

@@ -1,7 +1,10 @@
 import _ from 'lodash';
+import config from 'config';


Consider adding a check to ensure that the 'config' module is correctly configured and contains the necessary properties before using it. This can help prevent runtime errors if the configuration is missing or incorrect.

github-actions · 2025-06-02T22:46:53Z

src/routes/copilotRequest/approveRequest.service.js

-import { COPILOT_REQUEST_STATUS } from '../../constants';
+import { CONNECT_NOTIFICATION_EVENT, COPILOT_REQUEST_STATUS } from '../../constants';
+import util from '../../util';
+import { createEvent } from '../../services/busApi';


Ensure that the 'createEvent' function from 'busApi' is used correctly later in the code. If not already done, verify that it handles errors and edge cases appropriately.

github-actions · 2025-06-02T22:46:58Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +55,34 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))


The console.log(opportunity); statement has been removed, which is good for production code, but ensure that any necessary logging is still in place for debugging purposes.

Is there any reason to use console here instead of the req.log?

github-actions · 2025-06-02T22:46:58Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +55,34 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then(async (opportunity) => {
+                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);
+                const { subjects = [] } = await util.getRoleInfo(roles[0], req.log, req.id);


The console.log(roles, roleInfo, 'roles by copilot'); statement has been removed. Make sure that the necessary information is logged elsewhere if needed for debugging or auditing purposes.

github-actions · 2025-06-02T22:46:58Z

src/routes/copilotRequest/approveRequest.service.js

+                const emailEventType = CONNECT_NOTIFICATION_EVENT.COPILOT_OPPORTUNITY_CREATED;
+                const copilotPortalUrl = config.get('copilotPortalUrl');
+                req.log.info("Sending emails to all copilots about new opportunity");
+                subjects.forEach(subject => {


Consider handling the case where subjects might be an empty array to avoid unnecessary log entries or operations.

github-actions · 2025-06-02T22:46:58Z

src/routes/copilotRequest/approveRequest.service.js

+                const copilotPortalUrl = config.get('copilotPortalUrl');
+                req.log.info("Sending emails to all copilots about new opportunity");
+                subjects.forEach(subject => {
+                  req.log.info("Each copilot members", subject);


The log message 'Each copilot members' could be more descriptive. Consider including more context, such as the copilot's handle or email, to make the logs more informative.

github-actions · 2025-06-02T22:46:58Z

src/routes/copilotRequest/approveRequest.service.js

+                      name: config.get('EMAIL_INVITE_FROM_NAME'),
+                      email: config.get('EMAIL_INVITE_FROM_EMAIL'),
+                    },
+                    categories: [`${process.env.NODE_ENV}:${emailEventType}`.toLowerCase()],


Ensure that the category string is correctly formatted and consistent with other parts of the application to avoid issues with event categorization.

github-actions · 2025-06-02T22:47:01Z

src/util.js

+      }).then((res) => {
+        logger.debug(`Roles by ${roleName}: ${JSON.stringify(res.data.result.content)}`);
+        return _.get(res, 'data.result.content', [])
+          .filter(item => item.roleName === roleName)


Consider using a more descriptive variable name than item to improve code readability. For example, you could use role or roleItem to indicate that this represents a role object.

github-actions · 2025-06-02T23:17:18Z

src/util.js

+    try {
+      const token = yield this.getM2MToken();
+      const httpClient = this.getHttpClient({ id: requestId, log: logger });
+      httpClient.defaults.timeout = 6000;


Setting a timeout for the HTTP client is a good practice to prevent hanging requests. However, consider making the timeout value configurable through an environment variable or configuration file instead of hardcoding it. This would allow for easier adjustments in different environments or scenarios.

github-actions · 2025-06-04T14:44:43Z

src/util.js

+    try {
+      const token = yield this.getM2MToken();
+      const httpClient = this.getHttpClient({ id: requestId, log: logger });
+      httpClient.defaults.timeout = 6000;


Setting a timeout for the HTTP client is a good practice to prevent hanging requests. However, ensure that 6000 milliseconds is an appropriate timeout for all expected network conditions and use cases. Consider making this configurable if different timeouts might be needed in different environments.

github-actions · 2025-06-04T15:07:05Z

src/util.js

+        return _.get(res, 'data.result.content', []);
+      });
+    } catch (err) {
+      logger.debug(err, "error on getting role info");


Consider using a more descriptive error message to provide better context for debugging. For example, include information about the operation that failed or the parameters involved.

github-actions · 2025-06-05T19:19:34Z

src/constants.js

@@ -302,6 +302,9 @@ export const CONNECT_NOTIFICATION_EVENT = {
  TOPIC_UPDATED: 'connect.notification.project.topic.updated',
  POST_CREATED: 'connect.notification.project.post.created',
  POST_UPDATED: 'connect.notification.project.post.edited',
+
+  // External action email
+  EXTERNAL_ACTION_EMAIL: 'external.action.email',


The change from COPILOT_OPPORTUNITY_CREATED to EXTERNAL_ACTION_EMAIL seems to alter the meaning of the event. Ensure that this change aligns with the intended functionality described in the pull request. If the intention is to notify all copilots, verify that the event name accurately reflects this purpose.

github-actions · 2025-06-05T19:19:39Z

src/routes/copilotRequest/approveRequest.service.js

+                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);
+                req.log.info("getting subjects for roles", roles[0]);
+                const { subjects = [] } = await util.getRoleInfo(roles[0], req.log, req.id);
+                const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL;


The change of emailEventType from CONNECT_NOTIFICATION_EVENT.COPILOT_OPPORTUNITY_CREATED to CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL should be verified to ensure it aligns with the intended notification logic. This change might affect how the event is categorized or processed.

github-actions · 2025-06-05T19:19:39Z

src/routes/copilotRequest/approveRequest.service.js

+                  req.log.info("Each copilot members", subject);
+                  createEvent(emailEventType, {
+                    data: {
+                      user_name: subject.handle,


The key handle has been changed to user_name. Ensure that this change is compatible with the rest of the system and that any downstream dependencies are updated accordingly.

github-actions · 2025-06-05T19:19:39Z

src/routes/copilotRequest/approveRequest.service.js

+                      user_name: subject.handle,
+                      opportunityDetailsUrl: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
+                    },
+                    sendgrid_template_id: "d-3efdc91da580479d810c7acd50a4c17f",


The addition of sendgrid_template_id should be checked to confirm that the template ID d-3efdc91da580479d810c7acd50a4c17f is correct and that it exists in SendGrid. Also, verify that it matches the intended email format and content.

github-actions · 2025-06-05T19:19:39Z

src/routes/copilotRequest/approveRequest.service.js

+                    },
+                    sendgrid_template_id: "d-3efdc91da580479d810c7acd50a4c17f",
+                    recipients: [subject.email],
+                    version: '433b1688-c543-4656-a295-efcbea57444d',


The version field has been changed from 'v3' to '433b1688-c543-4656-a295-efcbea57444d'. Ensure that this version identifier is correct and that it corresponds to the expected versioning system or API.

github-actions · 2025-06-05T19:56:43Z

src/routes/copilotRequest/approveRequest.service.js

+                const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL;
+                const copilotPortalUrl = config.get('copilotPortalUrl');
+                req.log.info("Sending emails to all copilots about new opportunity");
+                req.log.info(`${copilotPortalUrl}/opportunity/${opportunity.id}`, '`${copilotPortalUrl}/opportunity/${opportunity.id}`');


The log statement seems to have a redundant string repetition. The second argument appears to be a duplicate of the first. Consider removing the duplicate string to avoid unnecessary repetition.

github-actions · 2025-06-08T22:24:25Z

src/routes/copilotRequest/approveRequest.service.js

+                  req.log.info("Each copilot members", subject);
+                  createEvent(emailEventType, {
+                    data: {
+                      userName: subject.handle,


The key user_name was changed to userName. Ensure that this change is reflected in all parts of the codebase where this key is used, including any documentation or external systems that might rely on the previous key format.

github-actions · 2025-06-10T01:28:45Z

src/routes/copilotRequest/approveRequest.service.js

+                  req.log.info("Each copilot members", subject);
+                  createEvent(emailEventType, {
+                    data: {
+                      user_name: subject.handle,


Consider using camelCase for consistency with JavaScript naming conventions. Change user_name to userName.

github-actions · 2025-06-10T01:28:45Z

src/routes/copilotRequest/approveRequest.service.js

+                  createEvent(emailEventType, {
+                    data: {
+                      user_name: subject.handle,
+                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,


Consider using camelCase for consistency with JavaScript naming conventions. Change opportunity_details_url to opportunityDetailsUrl.

github-actions · 2025-06-10T01:32:58Z

src/routes/copilotRequest/approveRequest.service.js

+                    },
+                    sendgrid_template_id: "d-3efdc91da580479d810c7acd50a4c17f",
+                    recipients: [subject.email],
+                    version: 'v3',


The version identifier has been changed from a specific UUID to 'v3'. Ensure that 'v3' is the correct and intended version for the sendgrid template. If 'v3' is a placeholder or not a valid version, it may cause issues in the notification process.

github-actions · 2025-06-10T03:56:12Z

src/routes/copilotOpportunityApply/create.js

@@ -65,7 +66,36 @@ module.exports = [
      }

      return models.CopilotApplication.create(data)
-        .then((result) => {
+        .then(async (result) => {
+          const pmRole = await util.getRolesByRoleName('Project Manager', req.log, req.id);


Consider adding error handling for the await util.getRolesByRoleName call to manage potential failures or exceptions.

github-actions · 2025-06-10T03:56:12Z

src/routes/copilotOpportunityApply/create.js

-        .then((result) => {
+        .then(async (result) => {
+          const pmRole = await util.getRolesByRoleName('Project Manager', req.log, req.id);
+          const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id);


Consider adding error handling for the await util.getRoleInfo call to manage potential failures or exceptions.

github-actions · 2025-06-10T03:56:12Z

src/routes/copilotOpportunityApply/create.js

+          const pmRole = await util.getRolesByRoleName('Project Manager', req.log, req.id);
+          const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id);
+
+          const creator = await util.getMemberDetailsByUserIds([req.authUser.userId], req.log, req.id);


Consider adding error handling for the await util.getMemberDetailsByUserIds call to manage potential failures or exceptions.

github-actions · 2025-06-10T03:56:12Z

src/routes/copilotOpportunityApply/create.js

+          const creator = await util.getMemberDetailsByUserIds([req.authUser.userId], req.log, req.id);
+          const listOfSubjects = subjects;
+          if (creator) {
+            const isCreatorPartofSubjects = subjects.find(item => item.email === creator[0].email);


The variable isCreatorPartofSubjects could be renamed to isCreatorPartOfSubjects to follow camelCase convention.

github-actions · 2025-06-10T03:56:12Z

src/routes/copilotOpportunityApply/create.js

+            const isCreatorPartofSubjects = subjects.find(item => item.email === creator[0].email);
+            if (!isCreatorPartofSubjects) {
+              listOfSubjects.push({
+                email: creator.email,


There is a potential issue here: creator.email should be creator[0].email to match the structure used in the isCreatorPartofSubjects check.

github-actions · 2025-06-10T03:56:12Z

src/routes/copilotOpportunityApply/create.js

+
+          const emailEventType = CONNECT_NOTIFICATION_EVENT.EXTERNAL_ACTION_EMAIL;
+          const copilotPortalUrl = config.get('copilotPortalUrl');
+          listOfSubjects.forEach((subject) => {


Consider adding error handling for the createEvent function call to manage potential failures or exceptions.

github-actions · 2025-06-10T03:56:15Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +55,29 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then(async (opportunity) => {
+                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);
+                const { subjects = [] } = await util.getRoleInfo(roles[0], req.log, req.id);


The log message for getting subjects for roles has been removed. If this was intentional, ensure that the removal does not affect the debugging process. If not, consider reinstating it for better traceability.

github-actions · 2025-06-10T03:56:15Z

src/routes/copilotRequest/approveRequest.service.js

+                const copilotPortalUrl = config.get('copilotPortalUrl');
+                req.log.info("Sending emails to all copilots about new opportunity");
+                subjects.forEach(subject => {
+                  req.log.info("Each copilot members", subject);


The log message for the copilot portal URL has been removed. If this was intentional, ensure that the removal does not affect the ability to trace the URL being used. If not, consider reinstating it for better traceability.

github-actions · 2025-06-10T03:59:23Z

src/routes/copilotOpportunityApply/create.js

+          const pmRole = await util.getRolesByRoleName('Project Manager', req.log, req.id);
+          const { subjects = [] } = await util.getRoleInfo(pmRole[0], req.log, req.id);
+
+          const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id);


The change from req.authUser.userId to opportunity.userId may affect the logic of fetching the creator's details. Ensure that opportunity.userId correctly represents the intended user in the context of notifying all copilots.

github-actions · 2025-06-10T08:51:05Z

src/routes/copilotOpportunityApply/create.js

+          if (creator) {
+            const isCreatorPartofSubjects = subjects.find(item => item.email === creator[0].email);
+            if (!isCreatorPartofSubjects) {
+              listOfSubjects.push({


It seems like creator is being accessed as an array with creator[0], but previously it was accessed as an object with creator.email. Ensure that creator is consistently treated as an array or an object throughout the code to avoid potential runtime errors.

kkartunov · 2025-06-10T09:58:32Z

src/routes/copilotOpportunityApply/create.js

@@ -65,7 +67,36 @@ module.exports = [
      }

      return models.CopilotApplication.create(data)
-        .then((result) => {
+        .then(async (result) => {
+          const pmRole = await util.getRolesByRoleName('Project Manager', req.log, req.id);


Please use enum/constant for the role name. Hardcoding it isn't good practice.

kkartunov · 2025-06-10T10:00:06Z

src/routes/copilotOpportunityApply/create.js

+          const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id);
+          const listOfSubjects = subjects;
+          if (creator) {
+            const isCreatorPartofSubjects = subjects.find(item => item.email === creator[0].email);


Can we compare lower case values here? Coul be some issues if we are not.

kkartunov · 2025-06-10T10:00:49Z

src/routes/copilotOpportunityApply/create.js

+                  user_name: subject.handle,
+                  opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}#applications`,
+                },
+                sendgrid_template_id: "d-d7c1f48628654798a05c8e09e52db14f",


Please conver sendgrid remplate id to constant.

kkartunov · 2025-06-10T10:02:24Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +55,29 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then(async (opportunity) => {
+                const roles = await util.getRolesByRoleName('copilot', req.log, req.id);


Conver role name to enum/constant. Do not use hardcoded names.

kkartunov · 2025-06-10T10:03:10Z

src/routes/copilotRequest/approveRequest.service.js

+                      user_name: subject.handle,
+                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
+                    },
+                    sendgrid_template_id: "d-3efdc91da580479d810c7acd50a4c17f",


Move the template id to constant.

github-actions · 2025-06-10T11:04:13Z

src/constants.js

+export const TEMPLATE_IDS = {
+  APPLY_COPILOT: 'd-d7c1f48628654798a05c8e09e52db14f',
+  CREATE_REQUEST: 'd-3efdc91da580479d810c7acd50a4c17f'
+}


Add a semicolon at the end of the object declaration for consistency with the rest of the codebase.

github-actions · 2025-06-10T11:04:17Z

src/routes/copilotOpportunityApply/create.js

@@ -65,7 +67,36 @@ module.exports = [
      }

      return models.CopilotApplication.create(data)
-        .then((result) => {
+        .then(async (result) => {
+          const pmRole = await util.getRolesByRoleName(USER_ROLE.PROJECT_MANAGER, req.log, req.id);


The change from a string to a constant USER_ROLE.PROJECT_MANAGER is a good practice for maintainability, but ensure that USER_ROLE is properly imported or defined in this file.

github-actions · 2025-06-10T11:04:17Z

src/routes/copilotOpportunityApply/create.js

+          const creator = await util.getMemberDetailsByUserIds([opportunity.userId], req.log, req.id);
+          const listOfSubjects = subjects;
+          if (creator) {
+            const isCreatorPartofSubjects = subjects.find(item => item.email.toLowerCase() === creator[0].email.toLowerCase());


Converting emails to lowercase for comparison is a good practice to ensure case-insensitive matching. However, ensure that both subjects and creator arrays are consistently handling email casing throughout the application to avoid any potential mismatches.

github-actions · 2025-06-10T11:04:22Z

src/routes/copilotRequest/approveRequest.service.js

@@ -52,6 +55,28 @@ module.exports = (data, existingTransaction) => {
                return models.CopilotOpportunity
                  .create(data, { transaction });
              }))
+              .then(async (opportunity) => {
+                const roles = await util.getRolesByRoleName(USER_ROLE.TC_COPILOT, req.log, req.id);


The change from a string 'copilot' to USER_ROLE.TC_COPILOT is good for consistency and maintainability, but ensure that USER_ROLE.TC_COPILOT is defined and correctly imported in this file.

github-actions · 2025-06-10T11:04:22Z

src/routes/copilotRequest/approveRequest.service.js

+                      user_name: subject.handle,
+                      opportunity_details_url: `${copilotPortalUrl}/opportunity/${opportunity.id}`,
+                    },
+                    sendgrid_template_id: TEMPLATE_IDS.CREATE_REQUEST,


The change to use TEMPLATE_IDS.CREATE_REQUEST instead of a hardcoded string is a good practice for maintainability. Ensure that TEMPLATE_IDS.CREATE_REQUEST is defined and correctly imported in this file.

github-actions · 2025-06-10T11:04:23Z

src/routes/copilotRequest/approveRequest.service.js

+                const copilotPortalUrl = config.get('copilotPortalUrl');
+                req.log.info("Sending emails to all copilots about new opportunity");
+                subjects.forEach(subject => {
+                  createEvent(emailEventType, {


The log statement 'Each copilot members' was removed. If this was intentional, ensure that the logging is still sufficient for debugging purposes. If not, consider adding a relevant log statement to track each copilot being notified.

kkartunov

Looks good.

feat: get roles by role name

79fdf6f

github-actions bot reviewed Jun 2, 2025

View reviewed changes

hentrymartin added 2 commits June 2, 2025 16:54

deploy feature branch

4b8c9f7

deploy feature branch

0c54ecf

github-actions bot reviewed Jun 2, 2025

View reviewed changes

deploy feature branch

223b7bd

github-actions bot reviewed Jun 2, 2025

View reviewed changes

deploy feature branch

82dd797

github-actions bot reviewed Jun 2, 2025

View reviewed changes

fix: get role by role name

9793dcc

github-actions bot reviewed Jun 2, 2025

View reviewed changes

modified timeout

5b29f65

github-actions bot reviewed Jun 2, 2025

View reviewed changes

hentrymartin added 3 commits June 4, 2025 12:04

rebased from develop branch

a29f1c9

rebased from develop branch

deaed3a

rebased from develop branch

d4ed7a9

github-actions bot reviewed Jun 4, 2025

View reviewed changes

rebased from develop branch

91f23ab

github-actions bot reviewed Jun 4, 2025

View reviewed changes

hentrymartin added 3 commits June 5, 2025 17:35

Merge branch 'develop' into pm-1173

fb9b8a9

fix: sync issue

31a2b66

fix: added external action email kaufka type

ae5952d

github-actions bot reviewed Jun 5, 2025

View reviewed changes

fix: added external action email kaufka type

c16d06e

github-actions bot reviewed Jun 5, 2025

View reviewed changes

fix: added external action email kaufka type

190c04c

github-actions bot reviewed Jun 8, 2025

View reviewed changes

fix: added external action email kaufka type

4c98fe7

github-actions bot reviewed Jun 10, 2025

View reviewed changes

fix: added external action email kaufka type

0ad22c3

github-actions bot reviewed Jun 10, 2025

View reviewed changes

fix: send emails to PMs and creator

cc5a28d

github-actions bot reviewed Jun 10, 2025

View reviewed changes

fix: send emails to PMs and creator

b52b16e

github-actions bot reviewed Jun 10, 2025

View reviewed changes

fix: send emails to PMs and creator

5fbd197

github-actions bot reviewed Jun 10, 2025

View reviewed changes

hentrymartin requested a review from kkartunov June 10, 2025 09:13

kkartunov requested changes Jun 10, 2025

View reviewed changes

fix: review comments

49356d6

github-actions bot reviewed Jun 10, 2025

View reviewed changes

fix: review comments

e34f785

kkartunov approved these changes Jun 10, 2025

View reviewed changes

hentrymartin merged commit 6f4cb68 into develop Jun 10, 2025
2 checks passed

hentrymartin deleted the pm-1173 branch June 10, 2025 15:47

		@@ -1,7 +1,10 @@
		import _ from 'lodash';
		import config from 'config';

feat(PM-1173): Notify all copilots on copilot opportunity #815

feat(PM-1173): Notify all copilots on copilot opportunity #815

Uh oh!

Conversation

hentrymartin commented Jun 2, 2025

What's in this PR?

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

kkartunov Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jun 2, 2025